Обсуждение: bug in 1.6 rc1
a)
I'm using the windows version of the latest 1.6rc1 release of pgAdmin-III, and have a consistently reproducible error.
Here are the steps to reproduce it:
After selecting a table, and using the context (right-click-popup) menu and choosing 'View Data->View All Rows' to get the Edit Data window, then selecting row and column defined as 'character varying(65000)', and editing the contained xml, moving away (clicking on another row) produces the following error message:
Subsequent attempts to move to another row produces a dialog box querying whether I want to save changes, which leads to another of the above messages appearing.
Ie: it enters some sort of loop where it knows data has not been saved, but errors out when trying to save it, which sets it up for another iteration of the error cycle.
b)
I rather like the ability to just bring up the entire table with a single click rather than continually having to navigate into the sub-menu of the context menu that appears when you're on a table / view type object in the hierarchy on the left.
Is there a way to customize the context menu so that the 'favourite' edit window option can be moved to the top layer of the context menu to save having to continually navigate into the sub-menu?
This would be a nice customization capability if it's not already there..... if it is already there, do tell.
Regards,
Peter.
NOTICE: This electronic mail transmission may contain confidential information and is intended only for the person(s) named. Any use, copying or disclosure by any other person is strictly prohibited. If you have received this transmission in error, please notify the sender via e-mail.
Вложения
Belbin, Peter wrote: > a) > > > > I'm using the windows version of the latest 1.6rc1 release of > pgAdmin-III, and have a consistently reproducible error. > > > > Here are the steps to reproduce it: > > > > After selecting a table, and using the context (right-click-popup) menu > and choosing 'View Data->View All Rows' to get the Edit Data window, > then selecting row and column defined as 'character varying(65000)', and > editing the contained xml, moving away (clicking on another row) > produces the following error message: > Can you enable query logging on your server and see what is actually being sent to the server please? > > Subsequent attempts to move to another row produces a dialog box > querying whether I want to save changes, which leads to another of the > above messages appearing. > > > Ie: it enters some sort of loop where it knows data has not been saved, > but errors out when trying to save it, which sets it up for another > iteration of the error cycle. > That's intended - it's so you don't lose the text you might have just spend five minutes typing in (which can be annoying if the error was caused by a simple constraint error for example. To get out of the loop, after you see the error either fix it, or hit the undo button to revert the changes you've made. > > > I rather like the ability to just bring up the entire table with a > single click rather than continually having to navigate into the > sub-menu of the context menu that appears when you're on a table / view > type object in the hierarchy on the left. > > > > Is there a way to customize the context menu so that the 'favourite' > edit window option can be moved to the top layer of the context menu to > save having to continually navigate into the sub-menu? > > > > This would be a nice customization capability if it's not already > there..... if it is already there, do tell. No, this is not currently possible on the context menu, but you can just hit the button on the toolbar. Regards, Dave
<p><font size="2">Seems that the closing quote is missing, along with a bunch of the previously existing column data.</font><p><fontsize="2">This appears to be the relevant portion:</font><p><font size="2">2006-11-06 09:25:46 QUERY : Scalar query (byoslab2:5432): SELECT version();</font><br /><font size="2">2006-11-06 09:25:46 QUERY : Query result:PostgreSQL 8.1.4 on sparc-sun-solaris2.9, compiled by GCC gcc (GCC) 3.3.2</font><br /><font size="2">2006-11-06 09:25:46QUERY : Void query (byoslab2:5432): UPDATE st_txn SET payload='<vsr><result><sbcs><sbc id="1"><sbcElement/><sbcName /><sbcName /><ip /></sbc><sbc id="2"><sbcElement /><sbcName/><sbcName /><ip /></sbc><sbcMarket /></sbcs><options><vpn_id>22222</vpn_id><dhcp_by>zzzz</dhcp_by><ip_helper_req>N/A</ip_helper_req><network_sec_int>FALSE</network_sec_int><default_gw_loc>No</default_gw_loc></options><ipspaces><subnet><circuitid>4444444</circuitid><ipaddress>10.0.1.1</ipaddress><network>10.0.1.0/24</network><default_router>10.0.1.1</default_router><primary_dns>10.0.0.5</primary_dns><secondary_dns>10.0.0.6</secondary_dns><cpe_primary_dns>111.222.333.2</cpe_primary_dns><cpe_secondary_dns>333.333.333.33</cpe_secondary_dns><domain_name /><ip_helper_primary/><ip_helper_secondary /><ip_route /><vpn_sbc_static_route_1 /><vpn_sbc_static_route_2/><wancpeip>88.888.888.88</wancpeip><LanStaticPool start="10.0.1.2" stop="10.0.1.100"/><LanDhcpPool start="10.0.1.101" stop="10.0.1.254" /><wanaggip>63.252.159.97</wanaggip><wannetwork>63.2</font><p><fontsize="2">2006-11-06 09:25:46 ERROR : ERROR: syntax error at end of input at character 2130</font><br /><br /><br /><br /><br /><br /><br /><br /><p><fontsize="2">-----Original Message-----</font><br /><font size="2">From: Dave Page [<a href="mailto:dpage@postgresql.org">mailto:dpage@postgresql.org</a>]</font><br /><font size="2">Sent: Saturday, November 04,2006 10:45 AM</font><br /><font size="2">To: Belbin, Peter</font><br /><font size="2">Cc: 'pgadmin-support@postgresql.org'</font><br/><font size="2">Subject: Re: [pgadmin-support] bug in 1.6 rc1</font><p><font size="2">Belbin,Peter wrote:</font><br /><font size="2">> a)</font><br /><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">> I'm using the windows version of the latest1.6rc1 release of </font><br /><font size="2">> pgAdmin-III, and have a consistently reproducible error.</font><br/><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">> </font><br /><fontsize="2">> Here are the steps to reproduce it:</font><br /><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">> After selecting a table, and using the context(right-click-popup) menu </font><br /><font size="2">> and choosing 'View Data->View All Rows' to get the EditData window, </font><br /><font size="2">> then selecting row and column defined as 'character varying(65000)', and</font><br /><font size="2">> editing the contained xml, moving away (clicking on another row) </font><br /><font size="2">>produces the following error message:</font><br /><font size="2">> </font><p><font size="2">Can you enablequery logging on your server and see what is actually </font><br /><font size="2">being sent to the server please?</font><p><fontsize="2">> </font><br /><font size="2">> Subsequent attempts to move to another row producesa dialog box </font><br /><font size="2">> querying whether I want to save changes, which leads to another ofthe </font><br /><font size="2">> above messages appearing.</font><br /><font size="2">> </font><br /><font size="2">></font><br /><font size="2">> Ie: it enters some sort of loop where it knows data has not been saved, </font><br/><font size="2">> but errors out when trying to save it, which sets it up for another </font><br /><font size="2">>iteration of the error cycle.</font><br /><font size="2">> </font><p><font size="2">That's intended - it'sso you don't lose the text you might have just </font><br /><font size="2">spend five minutes typing in (which can beannoying if the error was </font><br /><font size="2">caused by a simple constraint error for example. To get out of theloop, </font><br /><font size="2">after you see the error either fix it, or hit the undo button to revert </font><br /><fontsize="2">the changes you've made.</font><p><font size="2">> </font><br /><font size="2">> </font><br /><fontsize="2">> I rather like the ability to just bring up the entire table with a </font><br /><font size="2">>single click rather than continually having to navigate into the </font><br /><font size="2">> sub-menu ofthe context menu that appears when you're on a table / view </font><br /><font size="2">> type object in the hierarchyon the left.</font><br /><font size="2">> </font><br /><font size="2">> </font><br /><font size="2">></font><br /><font size="2">> Is there a way to customize the context menu so that the 'favourite' </font><br/><font size="2">> edit window option can be moved to the top layer of the context menu to </font><br /><fontsize="2">> save having to continually navigate into the sub-menu?</font><br /><font size="2">> </font><br /><fontsize="2">> </font><br /><font size="2">> </font><br /><font size="2">> This would be a nice customizationcapability if it's not already </font><br /><font size="2">> there..... if it is already there, do tell.</font><p><fontsize="2">No, this is not currently possible on the context menu, but you can just </font><br /><fontsize="2">hit the button on the toolbar.</font><p><font size="2">Regards, Dave</font><br /><br /><p><b><font size="2">NOTICE:This electronic mail transmission may contain confidential information and is intended only for the person(s)named. Any use, copying or disclosure by any other person is strictly prohibited. If you have received this transmissionin error, please notify the sender via e-mail.</font></b><br /><br />
Belbin, Peter wrote: > Seems that the closing quote is missing, along with a bunch of the > previously existing column data. > > This appears to be the relevant portion: > > 2006-11-06 09:25:46 QUERY : Scalar query (byoslab2:5432): SELECT > version(); > 2006-11-06 09:25:46 QUERY : Query result: PostgreSQL 8.1.4 on > sparc-sun-solaris2.9, compiled by GCC gcc (GCC) 3.3.2 > 2006-11-06 09:25:46 QUERY : Void query (byoslab2:5432): UPDATE st_txn > SET payload='<vsr><result><sbcs><sbc id="1"><sbcElement /><sbcName > /><sbcName /><ip /></sbc><sbc id="2"><sbcElement /><sbcName /><sbcName > /><ip /></sbc><sbcMarket > /></sbcs><options><vpn_id>22222</vpn_id><dhcp_by>zzzz</dhcp_by><ip_helper_req>N/A</ip_helper_req><network_sec_int>FALSE</network_sec_int><default_gw_loc>No</default_gw_loc></options><ipspaces><subnet><circuitid>4444444</circuitid><ipaddress>10.0.1.1</ipaddress><network>10.0.1.0/24</network><default_router>10.0.1.1</default_router><primary_dns>10.0.0.5</primary_dns><secondary_dns>10.0.0.6</secondary_dns><cpe_primary_dns>111.222.333.2</cpe_primary_dns><cpe_secondary_dns>333.333.333.33</cpe_secondary_dns><domain_name > /><ip_helper_primary /><ip_helper_secondary /><ip_route > /><vpn_sbc_static_route_1 /><vpn_sbc_static_route_2 > /><wancpeip>88.888.888.88</wancpeip><LanStaticPool start="10.0.1.2" > stop="10.0.1.100" /><LanDhcpPool start="10.0.1.101" stop="10.0.1.254" > /><wanaggip>63.252.159.97</wanaggip><wannetwork>63.2 > > 2006-11-06 09:25:46 ERROR : ERROR: syntax error at end of input at > character 2130 Hmm - can you supply me with a table definition and some sample data please? Regards, Dave.
<p><font size="2">Here is a table def:</font><p><font size="2">CREATE TABLE st_txn</font><br /><font size="2">(</font><br/><font size="2"> txnid varchar(40),</font><br /><font size="2"> txnorder varchar(10) NOT NULL,</font><br/><font size="2"> txnstage varchar(10) NOT NULL,</font><br /><font size="2"> txnseq varchar(10),</font><br/><font size="2"> verb varchar(40),</font><br /><font size="2"> payload varchar(65000),</font><br/><font size="2"> status varchar(10),</font><br /><font size="2"> agent varchar(60),</font><br/><font size="2"> id serial NOT NULL,</font><br /><font size="2"> CONSTRAINT st_txn_pk PRIMARY KEY(id)</font><br /><font size="2">) </font><br /><font size="2">WITH OIDS;</font><br /><p><font size="2">Here is some sampledata, copied from a problem row:</font><p><font size="2">190450;"";"969729832";"VSR";"";"";"<vsr><result><sbcs><sbcid="1"><sbcElement /><sbcName/><sbcName /><ip /></sbc><sbc id="2"><sbcElement /><sbcName /><sbcName/><ip /></sbc><sbcMarket /></sbcs><options><vpn_id>01117</vpn_id><dhcp_by>Customer</dhcp_by><ip_helper_req>No</ip_helper_req><network_sec_int>FALSE</network_sec_int><default_gw_loc>No</default_gw_loc></options><ipspaces><subnet><circuitid>4444444</circuitid><ipaddress>10.0.1.1</ipaddress><network>10.0.1.0/24</network><default_router>10.0.1.1</default_router><primary_dns /><secondary_dns /><cpe_primary_dns>333.333.333.3</cpe_primary_dns><cpe_secondary_dns>333.333.333.330</cpe_secondary_dns><domain_name /><ip_helper_primary/><ip_helper_secondary /><ip_route /><vpn_sbc_static_route_1 /><vpn_sbc_static_route_2/><wancpeip>33.333.333.333</wancpeip><LanStaticPool start="" stop="" /><LanDhcpPoolstart="" stop="" /><wanaggip>33.333.333.333</wanaggip><wannetwork>33.333.333.333/30</wannetwork></subnet></ipspaces><action><type>vpn</type><hosts><host>aaaaaaaaaaaaa01.bbbbbbbbb.NET</host></hosts><cmds timeout="20"><cmdid="1"><send><![CDATA[set routing-instance 01117 interface lsq-1/3/0.1]]></send></cmd><cmdid="2"><send><![CDATA[set routing-instance 01117 routing-optionsstatic route 33.333.333.333/30 preference 150]]></send></cmd><cmd id="3"><send><![CDATA[setrouting-instance 01117 routing-options static route 33.333.333.333/30 discard]]></send></cmd><cmdid="4"><send><![CDATA[set class-of-service interfaces lsq-1/3/0unit 1 scheduler-map VPN-Only]]></send></cmd><cmd id="5"><send><![CDATA[set class-of-serviceinterfaces lsq-1/3/0 unit 1 classifiers dscp VPN-Only]]></send></cmd><cmd id="6"><send><![CDATA[setrouting-instance 01117 routing-options static route 10.0.1.0/24 next-hop lsq-1/3/0.1]]></send></cmd></cmds></action><action><type>vpn</type><hosts><host>aaaaaaaaaaaaa02.bbbbbbbbb.NET</host></hosts><cmds timeout="20"><cmdid="1"><send><![CDATA[set routing-options static route 33.333.333.333/30 next-hop sp-1/3/0.76]]></send></cmd></cmds></action><code>OK</code></result></vsr>";"";"";4503</font><br /><br/><p><font size="2">-----Original Message-----</font><br /><font size="2">From: Dave Page [<a href="mailto:dpage@postgresql.org">mailto:dpage@postgresql.org</a>]</font><br /><font size="2">Sent: Monday, November 06,2006 10:12 AM</font><br /><font size="2">To: Belbin, Peter</font><br /><font size="2">Cc: 'pgadmin-support@postgresql.org'</font><br/><font size="2">Subject: Re: [pgadmin-support] bug in 1.6 rc1</font><p><font size="2">Belbin,Peter wrote:</font><br /><font size="2">> Seems that the closing quote is missing, along with a bunchof the </font><br /><font size="2">> previously existing column data.</font><br /><font size="2">> </font><br/><font size="2">> This appears to be the relevant portion:</font><br /><font size="2">> </font><br /><fontsize="2">> 2006-11-06 09:25:46 QUERY : Scalar query (byoslab2:5432): SELECT </font><br /><font size="2">> version();</font><br/><font size="2">> 2006-11-06 09:25:46 QUERY : Query result: PostgreSQL 8.1.4 on </font><br /><fontsize="2">> sparc-sun-solaris2.9, compiled by GCC gcc (GCC) 3.3.2</font><br /><font size="2">> 2006-11-06 09:25:46QUERY : Void query (byoslab2:5432): UPDATE st_txn </font><br /><font size="2">> SET payload='<vsr><result><sbcs><sbcid="1"><sbcElement /><sbcName </font><br /><font size="2">>/><sbcName /><ip /></sbc><sbc id="2"><sbcElement /><sbcName /><sbcName</font><br /><font size="2">> /><ip /></sbc><sbcMarket </font><br /><font size="2">> /></sbcs><options><vpn_id>22222</vpn_id><dhcp_by>zzzz</dhcp_by><ip_helper_req>N/A</ip_helper_req><network_sec_int>FALSE</network_sec_int><default_gw_loc>No</default_gw_loc></options><ipspaces><subnet><circuitid>4444444</circuitid><ipaddress>10.0.1.1</ipaddress><network>10.0.1.0/24</network><default_router>10.0.1.1</default_router><primary_dns>10.0.0.5</primary_dns><secondary_dns>10.0.0.6</secondary_dns><cpe_primary_dns>111.222.333.2</cpe_primary_dns><cpe_secondary_dns>333.333.333.33</cpe_secondary_dns><domain_name </font><p><fontsize="2">> /><ip_helper_primary /><ip_helper_secondary /><ip_route </font><br /><fontsize="2">> /><vpn_sbc_static_route_1 /><vpn_sbc_static_route_2 </font><br /><font size="2">> /><wancpeip>88.888.888.88</wancpeip><LanStaticPoolstart="10.0.1.2" </font><br /><font size="2">> stop="10.0.1.100"/><LanDhcpPool start="10.0.1.101" stop="10.0.1.254" </font><br /><font size="2">> /><wanaggip>63.252.159.97</wanaggip><wannetwork>63.2</font><br/><font size="2">> </font><br /><fontsize="2">> 2006-11-06 09:25:46 ERROR : ERROR: syntax error at end of input at </font><br /><font size="2">>character 2130</font><p><font size="2">Hmm - can you supply me with a table definition and some sample dataplease?</font><p><font size="2">Regards, Dave.</font><br /><br /><p><b><font size="2">NOTICE: This electronic mail transmissionmay contain confidential information and is intended only for the person(s) named. Any use, copying or disclosureby any other person is strictly prohibited. If you have received this transmission in error, please notify thesender via e-mail.</font></b><br /><br />
How is one (or is one) supposed to rename a DB through the pgAdmin UI? In 1.4.2 in the DB properties dialog the OK button becomes enabled if you changed the name in the dialog, but you get an error about renaming the current DB (there does not seem to be a way to not have that DB be your current DB). In 1.6 RC1, typing in a new name in the dialog does not enable the OK button and does not add the alter SQL to the SQL tab. I am wondering if this was a response to the 1.4.2 problem or if a bug. If it is a conscious change then graying the field out (as is done with the OID, tablespace, etc. fields) might be more appropriate otherwise the user is given mixed signals--he/she makes a change and nothing happens in response... And of course the big question is whether renaming through the UI should be supported. George
George Pavlov wrote: > How is one (or is one) supposed to rename a DB through the pgAdmin UI? > In 1.4.2 in the DB properties dialog the OK button becomes enabled if > you changed the name in the dialog, but you get an error about renaming > the current DB (there does not seem to be a way to not have that DB be > your current DB). In 1.6 RC1, typing in a new name in the dialog does > not enable the OK button and does not add the alter SQL to the SQL tab. > I am wondering if this was a response to the 1.4.2 problem or if a bug. > If it is a conscious change then graying the field out (as is done with > the OID, tablespace, etc. fields) might be more appropriate otherwise > the user is given mixed signals--he/she makes a change and nothing > happens in response... And of course the big question is whether > renaming through the UI should be supported. Hmm, the alter code is there (for generating the SQL at least) albeit with a minor bug (which is now fixed). It will never work though as it does indeed execute the SQL within the current DB. We don't have the necessary infrastructure in place to fix that now, so I've disabled the textbox for now. Thanks, Dave.
Belbin, Peter wrote: > Here is a table def: > > CREATE TABLE st_txn > ( > txnid varchar(40), > txnorder varchar(10) NOT NULL, > txnstage varchar(10) NOT NULL, > txnseq varchar(10), > verb varchar(40), > payload varchar(65000), > status varchar(10), > agent varchar(60), > id serial NOT NULL, > CONSTRAINT st_txn_pk PRIMARY KEY (id) > ) > WITH OIDS; Thanks. It appears that the error is actually that MakeKey() is failing to create a proper WHERE clause for the update query in cases where a table has both OIDs and a primary key. I've fixed that bug in SVN and your example now works fine. Thanks for the report. Regards, Dave.
<p><font size="2">Cool. Thank you for fixing it.</font><p><font size="2">Will the next packaged release candidate be anytime soon?</font><br /><p><font size="2">-----Original Message-----</font><br /><font size="2">From: Dave Page [<a href="mailto:dpage@postgresql.org">mailto:dpage@postgresql.org</a>]</font><br /><font size="2">Sent: Monday, November 06,2006 3:43 PM</font><br /><font size="2">To: Belbin, Peter</font><br /><font size="2">Cc: 'pgadmin-support@postgresql.org'</font><br/><font size="2">Subject: Re: [pgadmin-support] bug in 1.6 rc1</font><p><font size="2">Belbin,Peter wrote:</font><br /><font size="2">> Here is a table def:</font><br /><font size="2">> </font><br/><font size="2">> CREATE TABLE st_txn</font><br /><font size="2">> (</font><br /><font size="2">> txnidvarchar(40),</font><br /><font size="2">> txnorder varchar(10) NOT NULL,</font><br /><font size="2">> txnstagevarchar(10) NOT NULL,</font><br /><font size="2">> txnseq varchar(10),</font><br /><font size="2">> verbvarchar(40),</font><br /><font size="2">> payload varchar(65000),</font><br /><font size="2">> status varchar(10),</font><br/><font size="2">> agent varchar(60),</font><br /><font size="2">> id serial NOT NULL,</font><br/><font size="2">> CONSTRAINT st_txn_pk PRIMARY KEY (id)</font><br /><font size="2">> )</font><br/><font size="2">> WITH OIDS;</font><p><font size="2">Thanks. It appears that the error is actually that MakeKey()is failing </font><br /><font size="2">to create a proper WHERE clause for the update query in cases where a </font><br/><font size="2">table has both OIDs and a primary key. I've fixed that bug in SVN and </font><br /><font size="2">yourexample now works fine.</font><p><font size="2">Thanks for the report.</font><p><font size="2">Regards, Dave.</font><br/><br /><p><b><font size="2">NOTICE: This electronic mail transmission may contain confidential informationand is intended only for the person(s) named. Any use, copying or disclosure by any other person is strictlyprohibited. If you have received this transmission in error, please notify the sender via e-mail.</font></b><br /><br/>
Belbin, Peter wrote: > Cool. Thank you for fixing it. > > Will the next packaged release candidate be any time soon? There might not be another RC - we're getting dangerously close to PostgreSQL 8.2 release time and we have to be ready by then. Expect something within the week though I would think. Regards, Dave.