Обсуждение: Bug #926: if old postgresql.jar in CLASSPATH, ant fails
Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity of 3 The lower the number the more severe it is. Short Description if old postgresql.jar in CLASSPATH, ant fails Long Description See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 If there is an older postgresql.jar file in the ant classpath when building a new postgresql.jar, it will fail. Sample Code Adding includeAntRuntime="no" to the compile target in build.xml, as suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>,fixes the problem --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 @@ -101,7 +101,7 @@ <!-- This is the core of the driver. It is common for all three versions. --> <target name="compile" depends="prepare,check_versions,driver"> - <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> + <javac includeAntRuntime="no" srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> <include name="${package}/**" /> <exclude name="${package}/jdbc1/**" unless="jdbc1"/> No file was uploaded with this report
JDBC guys, what do you think of this fix? I don't see the change in CVS. --------------------------------------------------------------------------- pgsql-bugs@postgresql.org wrote: > Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity of 3 > The lower the number the more severe it is. > > Short Description > if old postgresql.jar in CLASSPATH, ant fails > > Long Description > See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 > > If there is an older postgresql.jar file in the ant classpath when building a new postgresql.jar, it will fail. > > Sample Code > Adding includeAntRuntime="no" to the compile target in build.xml, as suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>,fixes the problem > > --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 > +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 > @@ -101,7 +101,7 @@ > > <!-- This is the core of the driver. It is common for all three versions. --> > <target name="compile" depends="prepare,check_versions,driver"> > - <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > + <javac includeAntRuntime="no" srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > <include name="${package}/**" /> > > <exclude name="${package}/jdbc1/**" unless="jdbc1"/> > > > No file was uploaded with this report > > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Bruce Momjian wrote: > JDBC guys, what do you think of this fix? I don't see the change in CVS. > Well, it also fails if you have the old postgresql.jar in your java jre/lib/ext as well and there is no fixed way to exclude it that I know of. In general, the old jar should not be in any place that is searched. The user can have his/her CLASSPATH set to some place where the old jar file is. On the other hand setting includeAntRuntime="no" would not hurt us because we are not compiling an Ant (custom) task. Fernando > --------------------------------------------------------------------------- > > pgsql-bugs@postgresql.org wrote: > >>Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity of 3 >>The lower the number the more severe it is. >> >>Short Description >>if old postgresql.jar in CLASSPATH, ant fails >> >>Long Description >>See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 >> >>If there is an older postgresql.jar file in the ant classpath when building a new postgresql.jar, it will fail. >> >>Sample Code >>Adding includeAntRuntime="no" to the compile target in build.xml, as suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>,fixes the problem >> >>--- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 >>+++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 >>@@ -101,7 +101,7 @@ >> >> <!-- This is the core of the driver. It is common for all three versions. --> >> <target name="compile" depends="prepare,check_versions,driver"> >>- <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> >>+ <javac includeAntRuntime="no" srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> >> <include name="${package}/**" /> >> >> <exclude name="${package}/jdbc1/**" unless="jdbc1"/> >> >> >>No file was uploaded with this report >> >> >>---------------------------(end of broadcast)--------------------------- >>TIP 3: if posting/reading through Usenet, please send an appropriate >>subscribe-nomail command to majordomo@postgresql.org so that your >>message can get through to the mailing list cleanly >> > > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9
Is this patch valid for inclusion in jdbc? --------------------------------------------------------------------------- pgsql-bugs@postgresql.org wrote: > Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity of 3 > The lower the number the more severe it is. > > Short Description > if old postgresql.jar in CLASSPATH, ant fails > > Long Description > See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 > > If there is an older postgresql.jar file in the ant classpath when building a new postgresql.jar, it will fail. > > Sample Code > Adding includeAntRuntime="no" to the compile target in build.xml, as suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>,fixes the problem > > --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 > +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 > @@ -101,7 +101,7 @@ > > <!-- This is the core of the driver. It is common for all three versions. --> > <target name="compile" depends="prepare,check_versions,driver"> > - <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > + <javac includeAntRuntime="no" srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > <include name="${package}/**" /> > > <exclude name="${package}/jdbc1/**" unless="jdbc1"/> > > > No file was uploaded with this report > > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
It's been in use for the freebsd port for some months now, so I say yes. ;-) /Palle lördagen den 16 augusti 2003 kl 22.54 skrev Bruce Momjian: > > Is this patch valid for inclusion in jdbc? > > ----------------------------------------------------------------------- > ---- > > pgsql-bugs@postgresql.org wrote: >> Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity >> of 3 >> The lower the number the more severe it is. >> >> Short Description >> if old postgresql.jar in CLASSPATH, ant fails >> >> Long Description >> See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 >> >> If there is an older postgresql.jar file in the ant classpath when >> building a new postgresql.jar, it will fail. >> >> Sample Code >> Adding includeAntRuntime="no" to the compile target in build.xml, as >> suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>, fixes the >> problem >> >> --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 >> +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 >> @@ -101,7 +101,7 @@ >> >> <!-- This is the core of the driver. It is common for all three >> versions. --> >> <target name="compile" depends="prepare,check_versions,driver"> >> - <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> >> + <javac includeAntRuntime="no" srcdir="${srcdir}" >> destdir="${builddir}" debug="${debug}"> >> <include name="${package}/**" /> >> >> <exclude name="${package}/jdbc1/**" unless="jdbc1"/> >> >> >> No file was uploaded with this report >> >> >> ---------------------------(end of >> broadcast)--------------------------- >> TIP 3: if posting/reading through Usenet, please send an appropriate >> subscribe-nomail command to majordomo@postgresql.org so that your >> message can get through to the mailing list cleanly >> > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania > 19073
Yes, agreed Dave On Sun, 2003-08-17 at 09:57, Palle Girgensohn wrote: > It's been in use for the freebsd port for some months now, so I say > yes. ;-) > > /Palle > > lördagen den 16 augusti 2003 kl 22.54 skrev Bruce Momjian: > > > > > Is this patch valid for inclusion in jdbc? > > > > ----------------------------------------------------------------------- > > ---- > > > > pgsql-bugs@postgresql.org wrote: > >> Palle Girgensohn (girgen@pingpong.net) reports a bug with a severity > >> of 3 > >> The lower the number the more severe it is. > >> > >> Short Description > >> if old postgresql.jar in CLASSPATH, ant fails > >> > >> Long Description > >> See http://www.freebsd.org/cgi/query-pr.cgi?pr=48878 > >> > >> If there is an older postgresql.jar file in the ant classpath when > >> building a new postgresql.jar, it will fail. > >> > >> Sample Code > >> Adding includeAntRuntime="no" to the compile target in build.xml, as > >> suggested by Tetsurou Okazaki <okazaki@FreeBSD.org>, fixes the >> problem > >> > >> --- src/interfaces/jdbc/build.xml~ Sun Oct 20 02:10:55 2002 > >> +++ src/interfaces/jdbc/build.xml Mon Mar 3 12:10:37 2003 > >> @@ -101,7 +101,7 @@ > >> > >> <!-- This is the core of the driver. It is common for all three > >> versions. --> > >> <target name="compile" depends="prepare,check_versions,driver"> > >> - <javac srcdir="${srcdir}" destdir="${builddir}" debug="${debug}"> > >> + <javac includeAntRuntime="no" srcdir="${srcdir}" > >> destdir="${builddir}" debug="${debug}"> > >> <include name="${package}/**" /> > >> > >> <exclude name="${package}/jdbc1/**" unless="jdbc1"/> > >> > >> > >> No file was uploaded with this report > >> > >> > >> ---------------------------(end of > >> broadcast)--------------------------- > >> TIP 3: if posting/reading through Usenet, please send an appropriate > >> subscribe-nomail command to majordomo@postgresql.org so that your > >> message can get through to the mailing list cleanly > >> > > > > -- > > Bruce Momjian | http://candle.pha.pa.us > > pgman@candle.pha.pa.us | (610) 359-1001 > > + If your life is a hard drive, | 13 Roberts Road > > + Christ can be your backup. | Newtown Square, Pennsylvania > > 19073 > > > ---------------------------(end of broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to majordomo@postgresql.org) > -- Dave Cramer <Dave@micro-automation.net>