Обсуждение: broken contrib/dbsize in cvs head?

contrib/dbsize> make
gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes
-Wmissing-declarations -fpic -I. -I../../src/include -D_GNU_SOURCE   -c -o
dbsize.o dbsize.c
dbsize.c: In function `database_size':
dbsize.c:58: error: too few arguments to function `GetDatabasePath'
make: *** [dbsize.o] Error 1

It seems that GetDatabasePath was updated, but not all its callers were
fixed.

--
Fabien Coelho - coelho@cri.ensmp.fr

Fabien COELHO wrote:
> contrib/dbsize> make
> gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes
> -Wmissing-declarations -fpic -I. -I../../src/include -D_GNU_SOURCE   -c -o
> dbsize.o dbsize.c
> dbsize.c: In function `database_size':
> dbsize.c:58: error: too few arguments to function `GetDatabasePath'
> make: *** [dbsize.o] Error 1
>
> It seems that GetDatabasePath was updated, but not all its callers were
> fixed.

This is a known issue; there's a patch in pgsql-patches fixing this very
issue while still not tablespace-aware for tables, and another patch
proposing new functions which offer tablespace size as well.

Regards,
Andreas

> > It seems that GetDatabasePath was updated, but not all its callers were
> > fixed.
>
> This is a known issue; there's a patch in pgsql-patches fixing this very
> issue while still not tablespace-aware for tables, and another patch
> proposing new functions which offer tablespace size as well.

Ok. I must admit that I did not pay attention to the unapplied patches
queue.

Thanks,

--
Fabien Coelho - coelho@cri.ensmp.fr