Обсуждение: pgsql: Fix misuse of TextDatumGetCString().

Поиск
Список
Период
Сортировка

pgsql: Fix misuse of TextDatumGetCString().

От
Tom Lane
Дата:
Fix misuse of TextDatumGetCString().

"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*
is not a Datum.  Although this coding will accidentally fail to fail on
all known platforms, it risks leaking memory if a detoast step is needed,
unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's used
elsewhere.  Make pg_get_object_address() fall in line with other uses.

Noted while reviewing two-arg current_setting() patch.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/69e9f9639d5c569a71c82f99550e7bf2912664f1

Modified Files
--------------
src/backend/catalog/objectaddress.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)