Обсуждение: [PATCH] To remove EXTEND INDEX
Hi, As promised, here is a patch to remove all support for the (non-functional anyway) EXTEND INDEX statement. See earlier emails for more explanations. Note, this patch makes it as if it never existed. So, if you think some of the code may be useful, now is the time to speak up! :) Since this patch conflicts with my currently pending patch for partial indices, I put it here for review. I will submit a new patch to -patches once the other is in. http://svana.org/kleptog/pgsql/remove-extend.patch -- Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/ > It would be nice if someone came up with a certification system that > actually separated those who can barely regurgitate what they crammed over > the last few weeks from those who command secret ninja networking powers.
> Note, this patch makes it as if it never existed. So, if you think some of
> the code may be useful, now is the time to speak up! :)
Shouldn't this conversation be happening on the -hackers list? TIA
- Thomas
> > Note, this patch makes it as if it never existed. So, if you think some of > > the code may be useful, now is the time to speak up! :) > > Shouldn't this conversation be happening on the -hackers list? TIA Actually, because it had a patch attached, it should go to patches, right? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> > > > Note, this patch makes it as if it never existed. So, if you think some of > > > > the code may be useful, now is the time to speak up! :) > > > Shouldn't this conversation be happening on the -hackers list? TIA > > Actually, because it had a patch attached, it should go to patches, > > right? > > imho, no. Because there needs to be a discussion about whether to remove > code from the tree, and whether that code may be useful for something > else. > > -patches is designed to take actual patch files (to reduce bandwidth on > -hackers) but not to host planning discussions. If this had been a > simple patch without feature changes or other larger ramifications, then > it is more clearly a patch-only topic. What some people do is split the patch text with the actual patch. I don't like it sometimes, but I hesistate to post big patches to hachers, even if they require discussion. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
> Hi,
>
> As promised, here is a patch to remove all support for the (non-functional
> anyway) EXTEND INDEX statement. See earlier emails for more explanations.
>
> Note, this patch makes it as if it never existed. So, if you think some of
> the code may be useful, now is the time to speak up! :)
>
> Since this patch conflicts with my currently pending patch for partial
> indices, I put it here for review. I will submit a new patch to -patches
> once the other is in.
>
> http://svana.org/kleptog/pgsql/remove-extend.patch
> --
> Martijn van Oosterhout <kleptog@svana.org>
> http://svana.org/kleptog/
> > It would be nice if someone came up with a certification system that
> > actually separated those who can barely regurgitate what they crammed over
> > the last few weeks from those who command secret ninja networking powers.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl
>
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026