Обсуждение: Comments on patch for date_trunc( 'week', ... );
Per a brief conversation with Tom, I've created a patch for adding support for 'week' within the date_trunc function. Within the patch I added a couple of test cases and associated target output, and changed the documentation to add 'week' appropriately. Comments? Should I of bypassed this list and subscribed/posted to the patch list? Cheers, Rob -- 17:07:39 up 15 days, 46 min, 4 users, load average: 2.18, 2.23, 2.27 Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003
Вложения
Hey Bruce, I never saw the patch hit the hackers list. Did any of you smart folks take a look at it? Cheers, Rob When grilled further on (Wed, 3 Mar 2004 13:58:02 -0500 (EST)), Bruce Momjian <pgman@candle.pha.pa.us> confessed: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > I will try to apply it within the next 48 hours. > > --------------------------------------------------------------------------- > > > Robert Creager wrote: > -- Start of PGP signed section. > > > > Per a brief conversation with Tom, I've created a patch for adding support > > for'week' within the date_trunc function. > > > > Within the patch I added a couple of test cases and associated target > > output, and changed the documentation to add 'week' appropriately. > > > > Comments? Should I of bypassed this list and subscribed/posted to the patch > > list? > > > > Cheers, > > Rob > > > > -- > > 17:07:39 up 15 days, 46 min, 4 users, load average: 2.18, 2.23, 2.27 > > Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003 > > [ Attachment, skipping... ] > -- End of PGP section, PGP failed! > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > -- 20:21:06 up 18 days, 3:59, 2 users, load average: 1.52, 1.31, 1.25 Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003
Well, it must have hit the lists if I have put it in the patch queue, no? --------------------------------------------------------------------------- Hey Bruce, I never saw the patch hit the hackers list. Did any of you smart folks take a look at it? Cheers, Rob When grilled further on (Wed, 3 Mar 2004 13:58:02 -0500 (EST)), Bruce Momjian <pgman@candle.pha.pa.us> confessed: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > I will try to apply it within the next 48 hours. > > --------------------------------------------------------------------------- > > > Robert Creager wrote: > -- Start of PGP signed section. > > > > Per a brief conversation with Tom, I've created a patch for adding support > > for'week' within the date_trunc function. > > > > Within the patch I added a couple of test cases and associated target > > output, and changed the documentation to add 'week' appropriately. > > > > Comments? Should I of bypassed this list and subscribed/posted to the patch > > list? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
When grilled further on (Wed, 3 Mar 2004 22:40:50 -0500 (EST)), Bruce Momjian <pgman@candle.pha.pa.us> confessed: > > Well, it must have hit the lists if I have put it in the patch queue, no? > > --------------------------------------------------------------------------- > > Hey Bruce, > > I never saw the patch hit the hackers list. Did any of you smart folks take a > look at it? > More emphasis on the latter, less on the former. That was the gist of the e-mail, to make sure someone else actually looked at it ;-) Later, Rob -- 20:44:41 up 18 days, 4:22, 3 users, load average: 1.04, 1.12, 1.15 Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003
Patch applied. Thanks. --------------------------------------------------------------------------- Robert Creager wrote: -- Start of PGP signed section. > > Per a brief conversation with Tom, I've created a patch for adding support for > 'week' within the date_trunc function. > > Within the patch I added a couple of test cases and associated target output, > and changed the documentation to add 'week' appropriately. > > Comments? Should I of bypassed this list and subscribed/posted to the patch > list? > > Cheers, > Rob > > -- > 17:07:39 up 15 days, 46 min, 4 users, load average: 2.18, 2.23, 2.27 > Linux 2.4.21-0.13_test #60 SMP Sun Dec 7 17:00:02 MST 2003 [ Attachment, skipping... ] -- End of PGP section, PGP failed! -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073