Обсуждение: Re: [BUGS] Bug in create operator and/or initdb

Поиск
Список
Период
Сортировка

Re: [BUGS] Bug in create operator and/or initdb

От
Tom Lane
Дата:
Paul Vixie <paul@vix.com> writes:
> when my cidr datatype was integrated into pgsql, the decision was made to
> incorporate a copy of bind's inet_net_pton.c rather than add a link-time
> dependence to libbind.a (libbind.so).

We didn't really want to assume that all platforms are using libbind :-(

> thus, when this bug was fixed in 2003:

> ----------------------------
> revision 1.14
> date: 2003/08/20 02:21:08;  author: marka;  state: Exp;  lines: +10 -4
> 1580.   [bug]           inet_net_pton() didn't fully handle implicit
>                         multicast IPv4 network addresses.

> the pgsql "fork" of this code did not benefit from the fix.  the patch was:

Ah-hah.  Many thanks for supplying the patch --- will integrate it.
        regards, tom lane


Re: [BUGS] Bug in create operator and/or initdb

От
Paul Vixie
Дата:
> We didn't really want to assume that all platforms are using libbind :-(

i think you could have, at the time, since windows wasn't even a gleam in
pgsql's eye.  even now, libbind would be a dependable universal dependency,
since we publish windows binaries.

> > the pgsql "fork" of this code did not benefit from the fix.  the patch was:
> 
> Ah-hah.  Many thanks for supplying the patch --- will integrate it.

i have two suggestions.  first, look at the rest of the current source file,
in case there are other fixes.  second, track changes this source file during
your release engineering process for each new pgsql version.