Обсуждение: Patch review process; Warning to patch submitters

Поиск
Список
Период
Сортировка

Patch review process; Warning to patch submitters

От
Bruce Momjian
Дата:
Based on the patches status page:
http://developer.postgresql.org/index.php/Todo:PatchStatus#current_8.3_patch_status

we are a few weeks away from completing all patch review and entering
beta.  If you have been asked to updated your patch by a patch reviewer,
please do so in the next few days or your patch risks being held for
8.4.

Patch reviewers are not going to chase down patch authors to get patch
changes completed; one email request is sufficient, and I will back up
any patch reviewer who wants to hold a patch for 8.4 because the patch
was not updated by the patch author in a timely manner.

This holds true not only for patches where an update has already been
requested but for future requests for updates.  The original patch might
have made the April 1 deadline, but if it isn't updated promptly, then
it will be considered to be not ready to apply and be held for 8.4.

The bottom line is that the patch review process is hard enough, and we
need the assistance of patch submitters to work with the patch reviewers
in a timely manner.

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


Re: Patch review process; Warning to patch submitters

От
"Simon Riggs"
Дата:
On Fri, 2007-06-08 at 16:29 -0400, Bruce Momjian wrote:

> The bottom line is that the patch review process is hard enough, and we
> need the assistance of patch submitters to work with the patch reviewers
> in a timely manner.

This includes me, so: Understood.

There is a patch missing from the patch status page:
http://archives.postgresql.org/pgsql-hackers/2007-03/msg01795.php
http://archives.postgresql.org/pgsql-patches/2007-04/msg00250.php

Should I add it myself?

--  Simon Riggs              EnterpriseDB   http://www.enterprisedb.com




Re: Patch review process; Warning to patch submitters

От
Alvaro Herrera
Дата:
Simon Riggs wrote:
> On Fri, 2007-06-08 at 16:29 -0400, Bruce Momjian wrote:
> 
> > The bottom line is that the patch review process is hard enough, and we
> > need the assistance of patch submitters to work with the patch reviewers
> > in a timely manner.
> 
> This includes me, so: Understood.
> 
> There is a patch missing from the patch status page:
> http://archives.postgresql.org/pgsql-hackers/2007-03/msg01795.php
> http://archives.postgresql.org/pgsql-patches/2007-04/msg00250.php
> 
> Should I add it myself?

Sure, please do.

-- 
Alvaro Herrera                  http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"El sudor es la mejor cura para un pensamiento enfermo" (Bardia)