Обсуждение: Patch for automating partitions in PostgreSQL 8.4 Beta 2

Kedar,
 Added to first CommitFest of 8.5. Thanks for the nice test case.
 Folks who are not busy with 8.4 are urged to test this as soon as you can.



-- 
Josh Berkus
PostgreSQL Experts Inc.
www.pgexperts.com

make -C catalog all
( echo src/backend/catalog/catalog.o src/backend/catalog/dependency.o  
src/backend/catalog/heap.o src/backend/catalog/index.o src/backend/ 
catalog/indexing.o src/backend/catalog/namespace.o src/backend/catalog/ 
aclchk.o src/backend/catalog/pg_aggregate.o src/backend/catalog/ 
pg_constraint.o src/backend/catalog/pg_conversion.o src/backend/ 
catalog/pg_depend.o src/backend/catalog/pg_enum.o src/backend/catalog/ 
pg_inherits.o src/backend/catalog/pg_largeobject.o src/backend/catalog/ 
pg_namespace.o src/backend/catalog/pg_operator.o src/backend/catalog/ 
pg_proc.o src/backend/catalog/pg_shdepend.o src/backend/catalog/ 
pg_type.o src/backend/catalog/storage.o src/backend/catalog/ 
toasting.o ) >objfiles.txt
make[3]: *** No rule to make target `../../../src/include/catalog/ 
pg_partition.h', needed by `postgres.bki'.  Stop.
make[2]: *** [catalog-recursive] Error 2


(that's on mac os x).

On Mon, Jun 8, 2009 at 1:38 PM, Grzegorz Jaskiewicz <gj@pointblue.com.pl> wrote:
>
> make[3]: *** No rule to make target `../../../src/include/catalog/pg_partition.h', needed by `postgres.bki'.  Stop.

there is no pg_partition.h file in the patch, please send it


--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

gcc -no-cpp-precomp -O2 -Wall -Wmissing-prototypes -Wpointer-arith - 
Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing - 
fwrapv  -bundle -multiply_defined suppress  regress.o - 
bundle_loader ../../../src/backend/postgres  -L../../../src/port   -o  
regress.so
cp ../../../contrib/spi/refint.so refint.so
cp ../../../contrib/spi/autoinc.so autoinc.so
gcc -no-cpp-precomp -O2 -Wall -Wmissing-prototypes -Wpointer-arith - 
Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing - 
fwrapv  pg_regress.o pg_regress_main.o -L../../../src/port -Wl,- 
dead_strip_dylibs  -lpgport -lz -lreadline -lm  -o pg_regress
make -C config all
make[1]: Nothing to be done for `all'.

/bin/sh: /Users/gj/Projects/postgres-head/pgsql/partition.sh: No such  
file or directory

make: *** [all] Error 127

still doesn't work:

make[1]: Leaving directory `/home/gjaskie/Projects/postgres/pgsql/config'
/home/gjaskie/Projects/postgres/pgsql/partition.sh: line 14: a.keyorder,:
command not found
/home/gjaskie/Projects/postgres/pgsql/partition.sh: line 15: where: command not
found
: command not foundcts/postgres/pgsql/partition.sh: line 16:

Please make sure you test patches before sending here, on clean checkout!.

I did a fresh checkout and applied patch and added files and it works at my end.<br /><br />Is there any problem with
formattingof the file? May be some characters('\') missing in conversion?<br /><br /><div class="gmail_quote"> On Tue,
Jun9, 2009 at 4:14 PM, gj <span dir="ltr"><<a href="mailto:gj@pointblue.com.pl">gj@pointblue.com.pl</a>></span>
wrote:<br/><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex;
padding-left:1ex;"> still doesn't work:<br /><br /> make[1]: Leaving directory
`/home/gjaskie/Projects/postgres/pgsql/config'<br/> /home/gjaskie/Projects/postgres/pgsql/partition.sh: line 14:
a.keyorder,:<br/> command not found<br /> /home/gjaskie/Projects/postgres/pgsql/partition.sh: line 15: where: command
not<br/> found<br /> : command not foundcts/postgres/pgsql/partition.sh: line 16:<br /><br /> Please make sure you test
patchesbefore sending here, on clean checkout!.<br /><br /><br /><br /></blockquote></div><br /> 

On Tue, 9 Jun 2009 at 13:52:08, Kedar Potdar wrote:

> I did a fresh checkout and applied patch and added files and it works at my
> end.
>
> Is there any problem with formatting of the file? May be some
> characters('\') missing in conversion?
>
For one, I think you should put it around in quotes, when you echo something out
- just in case.
Second, isn't there any better way to do it, than in shell script ?
Shouldn't that bit be called on make check, not on build (make).?

On Mon, Jun 8, 2009 at 9:02 AM, Kedar Potdar<kedar.potdar@gmail.com> wrote:
> Hi,
>
> PFA patch, readme for automating partitions in PostgreSQL 8.4 Beta 2 and
> testcases.
>

if you are still working on this, can you please update the patch to cvs head?

--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157

Anyone knows what's the latest on that patch ?
To be honest, this was the thing that I was looking forward most in  
8.5 ... (and probably not only me alone).

Grzegorz Jaskiewicz wrote:
> Anyone knows what's the latest on that patch ?
> To be honest, this was the thing that I was looking forward most in 
> 8.5 ... (and probably not only me alone).
We are also interested in integrating our autopartitioning patch for 
COPY with that implementation. I can help with the partitioning 
implementation and/or testing of that feature since this is of interest 
for Aster too.

Emmanuel

-- 
Emmanuel Cecchet
Aster Data Systems
Web: http://www.asterdata.com