Обсуждение: [PATCH] elimination of code duplication in DefineOpFamily()

It looks like for me the bottom half of the DefineOpFamily() is
a block copied and pasted from CreateOpFamily().
It has identical logic, variable names and source code comments.

Perhaps, we can replace this code block by CreateOpFamily() call.

Thanks,
--
KaiGai Kohei <kaigai@ak.jp.nec.com>

I have not been able to find any comments or discussion on this patch.

Contents and Purpose:
================
This patch removes duplicate code in opclasscmds.c. It removes the 
duplicate code from DefineOpFamily by calling CreateOpFamily.

No new regression test or documentation are included with the patch. 
Since it is not adding, removing, or changing any functionality, they 
are most likely not necessary. The function call parameters remain the same.

Initial Run
========
The patch applied cleanly to HEAD. The regression tests pass both before 
and after the patch.

Performance
=========
No changes in performance were observed. I do not have an appropriate 
setup to properly test for performance impacts. Since this changes a 
define function, I would not expect it to be frequently used.

Conclusion
========
The patch eliminates duplicate code as expected.

Brent Dombrowski

Brent Dombrowski <brent.dombrowski@gmail.com> writes:
> [ review of KaiGai-san's patch ]

Committed.  Thanks for the patch, and the review.
        regards, tom lane