Обсуждение: Re: [COMMITTERS] pgsql: Document that the parenthesized VACUUM syntax is deprecated, not

On Fri, Mar 11, 2011 at 5:34 AM, Bruce Momjian <bruce@momjian.us> wrote:
> Document that the parenthesized VACUUM syntax is deprecated, not the
> FREEZE functionality.

The text you added here is flat-out wrong (you used "unparenthesized"
in both halves of the sentence), and it's also not as clear as the
text it replaced.  I'd suggest reverting this, and instead adding a
sentence that says simply:

The unparenthesized syntax is deprecated.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 11, 2011 at 7:58 AM, Bruce Momjian <bruce@momjian.us> wrote:
> Robert Haas wrote:
>> On Fri, Mar 11, 2011 at 5:34 AM, Bruce Momjian <bruce@momjian.us> wrote:
>> > Document that the parenthesized VACUUM syntax is deprecated, not the
>> > FREEZE functionality.
>>
>> The text you added here is flat-out wrong (you used "unparenthesized"
>> in both halves of the sentence), and it's also not as clear as the
>> text it replaced.  I'd suggest reverting this, and instead adding a
>> sentence that says simply:
>>
>> The unparenthesized syntax is deprecated.
>
> Fixed.  Other changes?  I didn't like the original sentence because it
> started by mentioning 9.0 rather than the syntax itself.

Hmm, well I don't know.  I thought the original phrasing was clearer.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Robert Haas wrote:
> On Fri, Mar 11, 2011 at 5:34 AM, Bruce Momjian <bruce@momjian.us> wrote:
> > Document that the parenthesized VACUUM syntax is deprecated, not the
> > FREEZE functionality.
>
> The text you added here is flat-out wrong (you used "unparenthesized"
> in both halves of the sentence), and it's also not as clear as the
> text it replaced.  I'd suggest reverting this, and instead adding a
> sentence that says simply:
>
> The unparenthesized syntax is deprecated.

Fixed.  Other changes?  I didn't like the original sentence because it
started by mentioning 9.0 rather than the syntax itself.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/doc/src/sgml/ref/vacuum.sgml b/doc/src/sgml/ref/vacuum.sgml
new file mode 100644
index 5b5b161..87283bc
*** a/doc/src/sgml/ref/vacuum.sgml
--- b/doc/src/sgml/ref/vacuum.sgml
*************** VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] A
*** 70,76 ****
     When the option list is surrounded by parentheses, the options can be
     written in any order.  Without parentheses, options must be specified
     in exactly the order shown above.
!    The unparenthesized syntax was added in
     <productname>PostgreSQL</productname> 9.0;  the unparenthesized
     syntax is deprecated.
    </para>
--- 70,76 ----
     When the option list is surrounded by parentheses, the options can be
     written in any order.  Without parentheses, options must be specified
     in exactly the order shown above.
!    The parenthesized syntax was added in
     <productname>PostgreSQL</productname> 9.0;  the unparenthesized
     syntax is deprecated.
    </para>