Обсуждение: PATCH: Allow distdir to be overridden on make command line

Поиск
Список
Период
Сортировка

PATCH: Allow distdir to be overridden on make command line

От
Craig Ringer
Дата:
Not just a one line patch, a one character patch.

Use ?= instead of = in distdir assignment, so it can be overridden on
the command line when building dist tarballs with patches.

Yes, you can just modify GNUMakefile.in, but that's extra noise in a
diff, adds merge conflicts, etc.

Please apply. Surely this is harmless?

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Вложения

Re: PATCH: Allow distdir to be overridden on make command line

От
Peter Eisentraut
Дата:
On Fri, 2014-08-29 at 10:04 +0800, Craig Ringer wrote:
> Not just a one line patch, a one character patch.
> 
> Use ?= instead of = in distdir assignment, so it can be overridden on
> the command line when building dist tarballs with patches.

This is already possible without this patch.

You can also override the VERSION variable.

Moreover, you might be interested in the configure option
--with-extra-version.




Re: PATCH: Allow distdir to be overridden on make command line

От
Michael Paquier
Дата:



On Sun, Aug 31, 2014 at 10:37 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On Fri, 2014-08-29 at 10:04 +0800, Craig Ringer wrote:
> Not just a one line patch, a one character patch.
>
> Use ?= instead of = in distdir assignment, so it can be overridden on
> the command line when building dist tarballs with patches.

This is already possible without this patch.

You can also override the VERSION variable.

Moreover, you might be interested in the configure option
--with-extra-version.
 
--with-extra-version is available as well with MSVC scripts on HEAD.
--
Michael