Обсуждение: Dereferenced pointer checks in data.c of ECPG

Поиск
Список
Период
Сортировка

Dereferenced pointer checks in data.c of ECPG

От
Michael Paquier
Дата:
Hi all,

ecpg_get_data@data.c is using to null-pointer checks for pval but it happens that we have the guarantee that those pointers are never NULL, see for example this piece of code at the code of ecpg_get_data():
        /* pval is a pointer to the value */
        if (!pval)
        {
                /*
                 * This should never happen because we already checked that we found
                 * at least one tuple, but let's play it safe.
                 */
                ecpg_raise(lineno, ECPG_NOT_FOUND, ECPG_SQLSTATE_NO_DATA, NULL);
                return (false);
        }
A patch is attached, and the issue has been spotted by Coverity.
Regards,
--
Michael
Вложения

Re: Dereferenced pointer checks in data.c of ECPG

От
Michael Meskes
Дата:
> A patch is attached, and the issue has been spotted by Coverity.
> Regards,

Thanks, committed.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL