Обсуждение: Buildfarm has got the measles

Поиск
Список
Период
Сортировка

Buildfarm has got the measles

От
Tom Lane
Дата:
A significant fraction of the buildfarm is showing this in HEAD:

***************
*** 375,382 **** create table rewritemetoo1 of rewritetype; create table rewritemetoo2 of rewritetype; alter type
rewritetypealter attribute a type text cascade;
 
- NOTICE:  Table 'rewritemetoo1' is being rewritten (reason = 4) NOTICE:  Table 'rewritemetoo2' is being rewritten
(reason= 4) -- but this doesn't work create table rewritemetoo3 (a rewritetype); alter type rewritetype alter attribute
atype varchar cascade;
 
--- 375,382 ---- create table rewritemetoo1 of rewritetype; create table rewritemetoo2 of rewritetype; alter type
rewritetypealter attribute a type text cascade; NOTICE:  Table 'rewritemetoo2' is being rewritten (reason = 4)
 
+ NOTICE:  Table 'rewritemetoo1' is being rewritten (reason = 4) -- but this doesn't work create table rewritemetoo3 (a
rewritetype);alter type rewritetype alter attribute a type varchar cascade;
 

======================================================================

Evidently the order in which child tables are visited isn't too stable.
I'm inclined to think that that's fine and this regression test needs
reconsideration.
        regards, tom lane



Re: Buildfarm has got the measles

От
Alvaro Herrera
Дата:
Tom Lane wrote:

> Evidently the order in which child tables are visited isn't too stable.
> I'm inclined to think that that's fine and this regression test needs
> reconsideration.

Thanks for pointing it out.

I was going to just drop one of the tables, but then thought it is worth
keeping a rewrites on multiple tables executed by a single command, and
that we can fix it by simply removing the table name in the NOTICE
message; I fixed it that way instead.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services