Обсуждение: Calling for a replacement committer for GROUPING SETS
In the light of Tom's comment in <22996.1425919278@sss.pgh.pa.us>: Tom> I will admit that I'm been slacking on commitfest work. This isTom> not unrelated to the fact that we've been in commitfestmodeTom> continuously since last August. I'm afraid whatever enthusiasm ITom> had for reviewing other peoples'patches burned out some time ago. I'm now requesting that some other committer take on the grouping sets patch. Any takers? -- Andrew (irc:RhodiumToad)
<p dir="ltr">Has there been anything controversial? What was causing it to take so long. I have time to work on it now<divclass="gmail_quote">On 9 Mar 2015 17:06, "Andrew Gierth" <<a href="mailto:andrew@tao11.riddles.org.uk">andrew@tao11.riddles.org.uk</a>>wrote:<br type="attribution" /><blockquote class="gmail_quote"style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In the light of Tom's comment in<<a href="mailto:22996.1425919278@sss.pgh.pa.us">22996.1425919278@sss.pgh.pa.us</a>>:<br /><br /> Tom> I willadmit that I'm been slacking on commitfest work. This is<br /> Tom> not unrelated to the fact that we've been incommitfest mode<br /> Tom> continuously since last August. I'm afraid whatever enthusiasm I<br /> Tom> had forreviewing other peoples' patches burned out some time ago.<br /><br /> I'm now requesting that some other committer takeon the grouping sets<br /> patch. Any takers?<br /><br /> --<br /> Andrew (irc:RhodiumToad)<br /><br /><br /> --<br/> Sent via pgsql-hackers mailing list (<a href="mailto:pgsql-hackers@postgresql.org">pgsql-hackers@postgresql.org</a>)<br/> To make changes to your subscription:<br/><a href="http://www.postgresql.org/mailpref/pgsql-hackers" target="_blank">http://www.postgresql.org/mailpref/pgsql-hackers</a><br/></blockquote></div>
On 2015-03-09 17:17:14 +0000, Greg Stark wrote: > Has there been anything controversial? What was causing it to take so long. > I have time to work on it now If you want to, you probably need to read the relevant thread. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
>>>>> "Greg" == Greg Stark <stark@mit.edu> writes: Greg> Has there been anything controversial? The major controversy is the idea of processing multiple sort orderings using a stacked chain of aggregate and sort nodes. I'll follow up shortly with links or a summary of the most significant criticisms; but note that the patch has already been fixed to keep the memory usage bounded regardless of the depth of the chain, so the issue is more about code and design aesthetics than about actually working. There is a description of the current approach in the block comment at the start of executor/nodeAgg.c. A less major issue is whether the introduction of GroupedVar was a good idea; I'm happy with ripping that out again, but if so the code needed to replace it depends on the resolution of the above point, so I've left it as originally submitted pending a decision on that. Greg> What was causing it to take so long. Tom claimed the reviewer/committer spot for himself five or six months ago, and other than the inadequate review and subsequent discussion in December there has been no progress. We posted the latest patch shortly after that (there was some slight delay thanks to the holiday season). Greg> I have time to work on it now Great. I'm actually about to post the latest patch with some tiny updates to match the recent changes in MemoryContextReset, but those are as much cosmetic as anything else (just removing no-longer-needed calls to MemoryContextDeleteChildren). -- Andrew (irc:RhodiumToad)
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> In the light of Tom's comment in <22996.1425919278@sss.pgh.pa.us>:
> Tom> I will admit that I'm been slacking on commitfest work. This is
> Tom> not unrelated to the fact that we've been in commitfest mode
> Tom> continuously since last August. I'm afraid whatever enthusiasm I
> Tom> had for reviewing other peoples' patches burned out some time ago.
> I'm now requesting that some other committer take on the grouping sets
> patch. Any takers?
FWIW, "slacking" doesn't mean "I've abandoned Postgres work completely".
I'm almost out from under some work-related deadlines (modulo the odd
plpgsql performance improvement patch or two ;-)) and expect to get
back to your patch and others in the CF before too long.
regards, tom lane
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes: >> I'm now requesting that some other committer take on the grouping>> sets patch. Any takers? Tom> FWIW, "slacking" doesn't mean "I've abandoned Postgres workTom> completely". I had taken your name off the patch in the CF and was planning to post this request even before I saw rhaas' post, much less your response. It's been almost six months since you claimed the patch, and three months since you said you would "look into" the question of the CTE-based approach per our discussion in December. So frankly I don't feel confident in your "expect ... before too long" ;-) So my request stands. I'll work with whoever gets to it first. -- Andrew (irc:RhodiumToad)