Обсуждение: Possibly a typo in expand_inherited_rtentry()

Hi,

Attached does:

     Index       childRTindex;
     AppendRelInfo *appinfo;

-    /* Open rel if needed; we already have required locks */
+    /* Open rel if needed; we already have acquired locks */
     if (childOID != parentOID)
         newrelation = heap_open(childOID, NoLock);
     else

Does that make sense?

Thanks,
Amit

On 03-04-2015 PM 03:58, Amit Langote wrote:
>      Index       childRTindex;
>      AppendRelInfo *appinfo;
> 
> -    /* Open rel if needed; we already have required locks */
> +    /* Open rel if needed; we already have acquired locks */
>      if (childOID != parentOID)
>          newrelation = heap_open(childOID, NoLock);

Though, it may be that "required" is to imply "acquired".

Thanks,
Amit

Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> Attached does:
> -    /* Open rel if needed; we already have required locks */
> +    /* Open rel if needed; we already have acquired locks */

> Does that make sense?

No, not particularly.  It could be made to say "the locks we require"
but I don't find anything wrong with the existing wording (and I'll
bet there is similar wording in many other places).
        regards, tom lane