Обсуждение: Apparently deprecated code in planner.c

Поиск
Список
Период
Сортировка

Apparently deprecated code in planner.c

От
"Dickson S. Guedes"
Дата:
Hi all,

I'm wondering whether the #ifdef FORCE_PARALLEL_MODE code [1] was deprecated:
    *    * FIXME: It's assumed that code further down will set parallelModeNeeded    * to true if a parallel path is
actuallychosen.  Since the core    * parallelism code isn't committed yet, this currently never happens.    */
 
#ifdef FORCE_PARALLEL_MODE   glob->parallelModeNeeded = glob->parallelModeOK;
#else   glob->parallelModeNeeded = false;
#endif


[1]
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/optimizer/plan/planner.c;h=147c4deef3bb708ebb32b6781330f6ed980fc90c;hb=HEAD#l245

[]s
-- 
Dickson S. Guedes
mail/xmpp: guedes@guedesoft.net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br



Re: Apparently deprecated code in planner.c

От
Robert Haas
Дата:
On Sun, Jan 10, 2016 at 5:28 PM, Dickson S. Guedes <listas@guedesoft.net> wrote:
> Hi all,
>
> I'm wondering whether the #ifdef FORCE_PARALLEL_MODE code [1] was deprecated:
>
>      *
>      * FIXME: It's assumed that code further down will set parallelModeNeeded
>      * to true if a parallel path is actually chosen.  Since the core
>      * parallelism code isn't committed yet, this currently never happens.
>      */
> #ifdef FORCE_PARALLEL_MODE
>     glob->parallelModeNeeded = glob->parallelModeOK;
> #else
>     glob->parallelModeNeeded = false;
> #endif

That comment is obsolete, but defining FORCE_PARALLEL_MODE is still a
useful thing to do for testing purposes.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company