Обсуждение: 64 Bit patch (WAS: psqlodbc developer)

Hi Karol,

I've forwarded this patch to the list for review before it's applied (I
don't use IODBC).

Please send any further patches to there as well so they can be properly
reviewed.

Thanks, Dave.

> -----Original Message-----
> From: Karol Szkudlarek [mailto:karol@mikronika.com.pl]
> Sent: 01 July 2004 22:10
> To: Dave Page
> Subject: Re: psqlodbc developer
>
> I checkout latest cvs trunk and you can't commit the
> following changes (from my patch.. :-)). I think that should
> be useful for IODBC version of the driver:
>
>
> diff -x .svn -x stamp-h1 -x .deps -x '*.*[oa]' -x 'config.*'
> psqlodbc-07.03.0200/iodbc.h psqlodbc-07.03.0200-my/iodbc.h
> 8a9
>  > #include <stdint.h>
> 28,30c29,31
> < typedef signed short SSHOR;
> < typedef short WORD;
> < typedef long DWORD;
> ---
>  > typedef int16_t SSHOR;
>  > typedef int16_t WORD;
>  > typedef int32_t DWORD;
> diff -x .svn -x stamp-h1 -x .deps -x '*.*[oa]' -x 'config.*'
> psqlodbc-07.03.0200/isql.h psqlodbc-07.03.0200-my/isql.h
> 8a9
>  > #ifdef WIN32
> 14c15,23
> <
> ---
>  > typedef unsigned char UCHAR;
>  > #else
>  > #include <stdint.h>
>  > typedef int32_t  SDWORD;
>  > typedef int16_t  SWORD;
>  > typedef uint32_t UDWORD;
>  > typedef uint16_t UWORD;
>  > typedef uint8_t UCHAR;
>  > #endif
>
> Am I right? :-)
>
> Greets,
> Karol
>
> ps.
>
> I am subscriber of psqlodbc mailing list since two months.. :-)
>
>
>
>
>
>

Am Freitag, 2. Juli 2004 10:45 schrieben Sie:
> I've forwarded this patch to the list for review before it's applied (I
> don't use IODBC).

If one uses iODBC then the include files are picked up from the installed
version of iODBC.  The files iodbc.h, isql.h, etc. in the source tree are
sort of obsolete.  They are only used for the "neither unixODBC nor iODBC"
version of the driver, which is quite useless.

> -----Original Message-----
> From: Peter Eisentraut [mailto:peter_e@gmx.net]
> Sent: 02 July 2004 10:06
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] 64 Bit patch (WAS: psqlodbc developer)
>
> Am Freitag, 2. Juli 2004 10:45 schrieben Sie:
> > I've forwarded this patch to the list for review before
> it's applied
> > (I don't use IODBC).
>
> If one uses iODBC then the include files are picked up from
> the installed version of iODBC.  The files iodbc.h, isql.h,
> etc. in the source tree are sort of obsolete.  They are only
> used for the "neither unixODBC nor iODBC"
> version of the driver, which is quite useless.

In which case, should they be removed to force the user to install
either iODBC or unixODBC first?

Regards, Dave.

Am Freitag, 2. Juli 2004 12:14 schrieb Dave Page:
> In which case, should they be removed to force the user to install
> either iODBC or unixODBC first?

This would be the right thing, I think, since I can't see any sense in
building a "neither" version.  If anyone does, please speak up.

> -----Original Message-----
> From: Peter Eisentraut [mailto:peter_e@gmx.net]
> Sent: 02 July 2004 15:23
> To: Dave Page
> Cc: pgsql-odbc@postgresql.org
> Subject: Re: [ODBC] 64 Bit patch (WAS: psqlodbc developer)
>
> Am Freitag, 2. Juli 2004 12:14 schrieb Dave Page:
> > In which case, should they be removed to force the user to install
> > either iODBC or unixODBC first?
>
> This would be the right thing, I think, since I can't see any
> sense in building a "neither" version.  If anyone does,
> please speak up.

OK, no objections so files removed.

Regards, Dave.