Обсуждение: Re: [HACKERS] Open Items (was: RE: [HACKERS] Beta going well)
New patch for open item: AIX compile (Peter E, Zeugswetter) (applies to today's snapshot) I now have a working autoconf, and was thus able to confirm, that Peter's SIZEOF_INT8 check works correctly on AIX. Please apply this patch before beta3, and please someone check BEOS which is also affected. Thank you Peter Andreas
"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes: /* Plain "long int" fits, use it */ + #if SIZEOF_INT8 == 0 typedef long int int64; + #endif + #if SIZEOF_UINT8 == 0 typedef unsigned long int uint64; + #endif This coding appears to assume "if the platform defines int8, then it will define int64 as well". Seems mighty fragile to me. regards, tom lane
> New patch for open item: AIX compile (Peter E, Zeugswetter) > (applies to today's snapshot) > > I now have a working autoconf, and was thus able to confirm, that > Peter's SIZEOF_INT8 check works correctly on AIX. > > Please apply this patch before beta3, and please someone check BEOS > which is also affected. The only problem I have now is that odbc/md5.h needs those unsigned defines and it can't probe the results of queries by configure. odbc allows for stand-alone compile. #if SIZEOF_UINT8 == 0 Right now it is testing for __BEOS__, which I believe is something set by the compiler and not by configure. My idea is to just unconditionally define the unsigned's in odbc. It will fail on a few platforms but I don't see another solution. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Zeugswetter Andreas SB SD writes: > New patch for open item: AIX compile (Peter E, Zeugswetter) > (applies to today's snapshot) > > I now have a working autoconf, and was thus able to confirm, that > Peter's SIZEOF_INT8 check works correctly on AIX. I'm confused a bit: In the previous message you added a check for uint64, in this version you removed the u?int64 checks completely. I suppose it doesn't matter, but is there a reason? -- Peter Eisentraut peter_e@gmx.net
Bruce Momjian writes: > The only problem I have now is that odbc/md5.h needs those unsigned > defines and it can't probe the results of queries by configure. odbc > allows for stand-alone compile. ODBC uses all kinds of other configure results, so it can use this one as well. You only need to make sure you hard-code the test result for Windows somewhere. -- Peter Eisentraut peter_e@gmx.net