Обсуждение: change output of \dp

Поиск
Список
Период
Сортировка

change output of \dp

От
Euler Taveira de Oliveira
Дата:
Hi,

I just noticed that \dp outputs "Table" to indicate relations (tables, sequences and views) instead of "Relation" or
"Name".This patch just correct it, using "Name"  and attaching its "Type". 

Without the patch:

teste=# \d
         List of relations
 Schema |  Name  |   Type   | Owner
--------+--------+----------+-------
 public | ab     | sequence | euler
 public | foo    | table    | euler
 public | foobar | view     | euler
 public | teste  | table    | euler
(4 rows)

teste=# \dp
                  Access privileges for database "teste"
 Schema | Table  |              Access privileges
--------+--------+---------------------------------------------
 public | ab     | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
 public | foo    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
 public | foobar |
 public | teste  | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
(4 rows)

And with the patch:

teste=# \dp
                  Access privileges for database "teste"
 Schema |  Name  |   Type   |              Access privileges
--------+--------+----------+---------------------------------------------
 public | ab     | sequence | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
 public | foo    | table    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
 public | foobar | view     |
 public | teste  | table    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
(4 rows)

Please apply it under HEAD, and if it's convenient, put it under 7_4 Branch.

Regards,

--
Euler Taveira de Oliveira
euler (at) ufgnet.ufg.br
Desenvolvedor Web e Administrador de Sistemas
UFGNet - Universidade Federal de Goiás

Вложения

Re: change output of \dp

От
Neil Conway
Дата:
Euler Taveira de Oliveira <euler@ufgnet.ufg.br> writes:
> I just noticed that \dp outputs "Table" to indicate relations
> (tables, sequences and views) instead of "Relation" or "Name". This
> patch just correct it, using "Name" and attaching its "Type".

Looks good to me.

> Please apply it under HEAD, and if it's convenient, put it under 7_4
> Branch.

This is appropriate for HEAD, but I don't see any need to apply it to
7.4: it is just a cosmetic fix.

-Neil


Re: change output of \dp

От
Bruce Momjian
Дата:
Neil Conway wrote:
> Euler Taveira de Oliveira <euler@ufgnet.ufg.br> writes:
> > I just noticed that \dp outputs "Table" to indicate relations
> > (tables, sequences and views) instead of "Relation" or "Name". This
> > patch just correct it, using "Name" and attaching its "Type".
>
> Looks good to me.
>
> > Please apply it under HEAD, and if it's convenient, put it under 7_4
> > Branch.
>
> This is appropriate for HEAD, but I don't see any need to apply it to
> 7.4: it is just a cosmetic fix.

Agreed.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: change output of \dp

От
Euler Taveira de Oliveira
Дата:
Hi,

I just forgot the documentation patch. It's attached.

Regards,

--
Euler Taveira de Oliveira
euler (at) ufgnet.ufg.br
Desenvolvedor Web e Administrador de Sistemas
UFGNet - Universidade Federal de Goiás


Вложения

Re: change output of \dp

От
Peter Eisentraut
Дата:
Euler Taveira de Oliveira wrote:
> I just noticed that \dp outputs "Table" to indicate relations
> (tables, sequences and views) instead of "Relation" or "Name". This
> patch just correct it, using "Name"  and attaching its "Type".

Maybe we should think of a more general solution.  For example, there is
still not any way to show the privileges of functions and other
objects.


Re: change output of \dp

От
Euler Taveira de Oliveira
Дата:
Hi,

> > I just noticed that \dp outputs "Table" to indicate relations
> > (tables, sequences and views) instead of "Relation" or "Name". This
> > patch just correct it, using "Name"  and attaching its "Type".
>
> Maybe we should think of a more general solution.  For example, there is
> still not any way to show the privileges of functions and other
> objects.
>
>
I could do it, if nobody objects.

--
Euler Taveira de Oliveira
euler (at) ufgnet.ufg.br
Desenvolvedor Web e Administrador de Sistemas
UFGNet - Universidade Federal de Goiás

Re: change output of \dp

От
Bruce Momjian
Дата:
Euler Taveira de Oliveira wrote:
> Hi,
>
> > > I just noticed that \dp outputs "Table" to indicate relations
> > > (tables, sequences and views) instead of "Relation" or "Name". This
> > > patch just correct it, using "Name"  and attaching its "Type".
> >
> > Maybe we should think of a more general solution.  For example, there is
> > still not any way to show the privileges of functions and other
> > objects.
> >
> >

> I could do it, if nobody objects.

Sounds good.  Do you want your original patch applied?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: change output of \dp

От
Euler Taveira de Oliveira
Дата:
Hi Bruce,

>
> Sounds good.  Do you want your original patch applied?
>
Sorry for the delay, i just redo the patch and change some documentation. Please apply the attached patch.
I will change the discussion for -hackers about some ideas to improve access privileges output.

Regards,

--
Euler Taveira de Oliveira
euler (at) ufgnet.ufg.br
Desenvolvedor Web e Administrador de Sistemas
UFGNet - Universidade Federal de Goiás

Вложения

Re: change output of \dp

От
Bruce Momjian
Дата:
Newest version of patch applied.  Thanks.

Handles views and sequences.

---------------------------------------------------------------------------


Euler Taveira de Oliveira wrote:
> Hi,
>
> I just noticed that \dp outputs "Table" to indicate relations (tables, sequences and views) instead of "Relation" or
"Name".This patch just correct it, using "Name"  and attaching its "Type". 
>
> Without the patch:
>
> teste=# \d
>          List of relations
>  Schema |  Name  |   Type   | Owner
> --------+--------+----------+-------
>  public | ab     | sequence | euler
>  public | foo    | table    | euler
>  public | foobar | view     | euler
>  public | teste  | table    | euler
> (4 rows)
>
> teste=# \dp
>                   Access privileges for database "teste"
>  Schema | Table  |              Access privileges
> --------+--------+---------------------------------------------
>  public | ab     | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
>  public | foo    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
>  public | foobar |
>  public | teste  | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
> (4 rows)
>
> And with the patch:
>
> teste=# \dp
>                   Access privileges for database "teste"
>  Schema |  Name  |   Type   |              Access privileges
> --------+--------+----------+---------------------------------------------
>  public | ab     | sequence | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
>  public | foo    | table    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
>  public | foobar | view     |
>  public | teste  | table    | {euler=a*r*w*d*R*x*t*/euler,teste=ar/euler}
> (4 rows)
>
> Please apply it under HEAD, and if it's convenient, put it under 7_4 Branch.
>
> Regards,
>
> --
> Euler Taveira de Oliveira
> euler (at) ufgnet.ufg.br
> Desenvolvedor Web e Administrador de Sistemas
> UFGNet - Universidade Federal de Goi?s

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
>                http://archives.postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: change output of \dp

От
Bruce Momjian
Дата:
This is the one applied.

---------------------------------------------------------------------------

Euler Taveira de Oliveira wrote:
> Hi Bruce,
>
> >
> > Sounds good.  Do you want your original patch applied?
> >
> Sorry for the delay, i just redo the patch and change some documentation. Please apply the attached patch.
> I will change the discussion for -hackers about some ideas to improve access privileges output.
>
> Regards,
>
> --
> Euler Taveira de Oliveira
> euler (at) ufgnet.ufg.br
> Desenvolvedor Web e Administrador de Sistemas
> UFGNet - Universidade Federal de Goi?s

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073