Обсуждение: Sign me up

Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months
ago;)  I'm not strong in C either, but I'll nut it out. 

On 11/14/2011 04:17 PM, Royce Ausburn wrote:
> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of
monthsago ;)  I'm not strong in C either, but I'll nut it out. 
>

How about "Include detailed information about a row failing a CHECK
constraint into the error message"?  There's not a lot of code there,
the main review work is preparing a test case that demonstrates the code
does its job.  (One really should have been included with the patch, but
this condition isn't difficult to recreate)  If that sounds reasonable,
just edit the patch and add yourself there.  I see you've already
created your own entry there, so you know how that works.

--
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support  www.2ndQuadrant.us

On 15/11/2011, at 12:52 PM, Greg Smith wrote:

> On 11/14/2011 04:17 PM, Royce Ausburn wrote:
>> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of
monthsago ;)  I'm not strong in C either, but I'll nut it out. 
>>
>
> How about "Include detailed information about a row failing a CHECK constraint into the error message"?  There's not
alot of code there, the main review work is preparing a test case that demonstrates the code does its job.  (One really
shouldhave been included with the patch, but this condition isn't difficult to recreate)  If that sounds reasonable,
justedit the patch and add yourself there.  I see you've already created your own entry there, so you know how that
works.

Thanks Greg.  I've added myself.  I'll review it in the next couple of days.