Обсуждение: Re: pgAdminIV : Regression tests code cleanup
Awesome - the test suite just found it's first bug! There was a code path that referenced a variable that hadn't been defined, added in a patch that I committed earlier without spotting the issue. The associated tests failed, and I pretty quickly spotted (and fixed) the bug as a result :-D Patch applied! On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote: > Hi Dave, > Please find the patch of test framework, which contains > 1. Code changes (due to drop objects functionality). > 2. Quoting for database names in drop databases. > 3. Code changes for import errors for pickle_path and advanced_config > variables. > > Run test suite by this command: > python runtests.py > > Thanks. > -- > Regards, > Navnath Gadakh > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
Thanks Dave.
On Fri, Oct 7, 2016 at 6:31 PM, Dave Page <dave.page@enterprisedb.com> wrote:
Awesome - the test suite just found it's first bug! There was a code
path that referenced a variable that hadn't been defined, added in a
patch that I committed earlier without spotting the issue. The
associated tests failed, and I pretty quickly spotted (and fixed) the
bug as a result :-D
Patch applied!--
On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
> Please find the patch of test framework, which contains
> 1. Code changes (due to drop objects functionality).
> 2. Quoting for database names in drop databases.
> 3. Code changes for import errors for pickle_path and advanced_config
> variables.
>
> Run test suite by this command:
> python runtests.py
>
> Thanks.
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Regards,
Navnath Gadakh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
The Enterprise PostgreSQL Company