Обсуждение: Document how to set up TAP tests for Perl 5.8.8
I found it a real pain to set up Perl 5.8.8 to re-check recent TAP changes against it. It turns out there's a much easier way than messing with VMs or manually doing a source install, so I documented it to save others the future pain. It'd be nice to commit this at least to 9.6 and v10. Trivial one-file docs patch. There's no README to patch in 9.4 or 9.5. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Вложения
On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: > --- a/src/test/perl/README > +++ b/src/test/perl/README > @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the > perldoc for the test modules, e.g.: > > perldoc src/test/perl/PostgresNode.pm > + > +Required Perl > +------------- > + > +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain Tests must run on Perl 5.8.0 and newer.
On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch <noah@leadboat.com> wrote: > On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >> --- a/src/test/perl/README >> +++ b/src/test/perl/README >> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the >> perldoc for the test modules, e.g.: >> >> perldoc src/test/perl/PostgresNode.pm >> + >> +Required Perl >> +------------- >> + >> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain > > Tests must run on Perl 5.8.0 and newer. Hm? I thought that 5.8.8 was the minimum supported by recalling the precious discussions. That's as well the oldest version of perldoc, which is kind of useful. Anyway it would be nice to mention the minimum requirements directly in src/test/perl/README? -- Michael
On 17 November 2016 at 00:01, Michael Paquier <michael.paquier@gmail.com> wrote: > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch <noah@leadboat.com> wrote: >> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >>> --- a/src/test/perl/README >>> +++ b/src/test/perl/README >>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the >>> perldoc for the test modules, e.g.: >>> >>> perldoc src/test/perl/PostgresNode.pm >>> + >>> +Required Perl >>> +------------- >>> + >>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain >> >> Tests must run on Perl 5.8.0 and newer. Why? We've always discussed 5.8.8 before. That's already a full 10 years old. 5.8.0 is from *2002*. Are you running any 15-year-old systems you can't update to a *patch release* of the same perl major? gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the only relevant thing I can find, and it's not relevant to the TAP tests anyway. BTW, here's my older approach, with a dockerfile, before I became aware of perlbrew: https://www.postgresql.org/message-id/CAMsr+YGR6pU-gUyp-FT98XwXAsc9n6j-awZAqxvW_+P3RTC7cg@mail.gmail.com 5.8.8 is in CentOS 5. Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8. Etch came out in early 2007. Even Sarge had 5.8.4. Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 . So unless we care about Debian 3 Sarge or source builds done more than 10 years ago, 5.8.8 is more than good enough. -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
Hello, At Thu, 17 Nov 2016 10:00:53 +0800, Craig Ringer <craig@2ndquadrant.com> wrote in <CAMsr+YEmmS8XP8Oj6vu2J+TM3SP_AnjCL3k6TsOfk2FxaUXOkg@mail.gmail.com> > On 17 November 2016 at 00:01, Michael Paquier <michael.paquier@gmail.com> wrote: > > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch <noah@leadboat.com> wrote: > >> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: > >>> --- a/src/test/perl/README > >>> +++ b/src/test/perl/README > >>> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some example tests read the > >>> perldoc for the test modules, e.g.: > >>> > >>> perldoc src/test/perl/PostgresNode.pm > >>> + > >>> +Required Perl > >>> +------------- > >>> + > >>> +Tests must run on perl 5.8.8 and newer. perlbrew is a good way to obtain > >> > >> Tests must run on Perl 5.8.0 and newer. > > Why? We've always discussed 5.8.8 before. That's already a full 10 years old. > > 5.8.0 is from *2002*. Are you running any 15-year-old systems you > can't update to a *patch release* of the same perl major? > > > gendef.pl says it needs 5.8.0 or newer with "use 5.8.0" but that's the > only relevant thing I can find, and it's not relevant to the TAP tests > anyway. > > BTW, here's my older approach, with a dockerfile, before I became > aware of perlbrew: > > https://www.postgresql.org/message-id/CAMsr+YGR6pU-gUyp-FT98XwXAsc9n6j-awZAqxvW_+P3RTC7cg@mail.gmail.com > > > 5.8.8 is in CentOS 5. > > Debian Lenny (6) has 5.14.2 Wheezy (5) has 5.10. Etch (4) has 5.8.8. > Etch came out in early 2007. Even Sarge had 5.8.4. > > Ubuntu 10.04 Lucid (old-lts) had 5.10.1-8ubuntu2 . > > So unless we care about Debian 3 Sarge or source builds done more than > 10 years ago, 5.8.8 is more than good enough. I vote +1 to upgrading perl, but I'm not sure if all supporting platforms other than linux support the version of perl. Anyway ./configure is saying as the following. | *** The installed version of Perl, $PERL, is too old to use with PostgreSQL. | *** Perl version 5.8 or later is required, but this is $pgac_perl_version." >&5 If TAP test requires 5.8.8, the whole build sequence should follow that. Or at least ./configure --enable-tap-tests should check that. regards, -- Kyotaro Horiguchi NTT Open Source Software Center
On 17 November 2016 at 10:31, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote: > > I vote +1 to upgrading perl, but I'm not sure if all supporting > platforms other than linux support the version of perl. > > Anyway ./configure is saying as the following. > > | *** The installed version of Perl, $PERL, is too old to use with PostgreSQL. > | *** Perl version 5.8 or later is required, but this is $pgac_perl_version." >&5 > > If TAP test requires 5.8.8, the whole build sequence should > follow that. Or at least ./configure --enable-tap-tests should > check that. I wrote 5.8.8 because that's what we've always discussed before and I could honestly not imagine it mattering whether we require 10-year or 15-year old Perl. Especially for the TAP tests, which are new, and optional. I really don't think it matters if the TAP tests use a slightly newer Perl. They're optional and not enabled by default. Can we just document this please? I didn't think a four-line docs patch to an optional, non-default, new test suite would require this kind of discussion. But sure, if it's easier, we can have 5.8.0 in the README. What's five extra years matter anyway? Hey, while we're at it, lets change Pg to build on Borland C and require K&R style! -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On 17 November 2016 at 10:42, Craig Ringer <craig@2ndquadrant.com> wrote: > But sure, if it's easier, we can have 5.8.0 in the README. What's five > extra years matter anyway? Hey, while we're at it, lets change Pg to > build on Borland C and require K&R style! Sorry. That was unnecessary. I should've had the sense to save that as a draft and come back later. In all seriousness, though, lets query the buildfarm database for Perl versions. Let it answer. -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
At Thu, 17 Nov 2016 10:42:54 +0800, Craig Ringer <craig@2ndquadrant.com> wrote in <CAMsr+YG_S+kAvcSoaOKfVeFgG2An_D+NSap7H3HCV+hTRduPWQ@mail.gmail.com> > On 17 November 2016 at 10:31, Kyotaro HORIGUCHI > <horiguchi.kyotaro@lab.ntt.co.jp> wrote: > > > > > I vote +1 to upgrading perl, but I'm not sure if all supporting > > platforms other than linux support the version of perl. > > > > Anyway ./configure is saying as the following. > > > > | *** The installed version of Perl, $PERL, is too old to use with PostgreSQL. > > | *** Perl version 5.8 or later is required, but this is $pgac_perl_version." >&5 > > > > If TAP test requires 5.8.8, the whole build sequence should > > follow that. Or at least ./configure --enable-tap-tests should > > check that. > > I wrote 5.8.8 because that's what we've always discussed before and I > could honestly not imagine it mattering whether we require 10-year or > 15-year old Perl. Especially for the TAP tests, which are new, and > optional. > > I really don't think it matters if the TAP tests use a slightly newer > Perl. They're optional and not enabled by default. Can we just If so, why explicitly require 5.8.8? I think it is because the 'slight' difference actually prevent the test from running. > document this please? I didn't think a four-line docs patch to an > optional, non-default, new test suite would require this kind of > discussion. My only concern is the fact that 'make check-world' runs the TAP tests as a part if --enable-tap-tests (according to release-9.4.sgml, but I haven't done by myself.). I completely agree to you if it didn't run as a part of top-level 'make <some kind of check>'. > But sure, if it's easier, we can have 5.8.0 in the README. What's five > extra years matter anyway? Hey, while we're at it, lets change Pg to > build on Borland C and require K&R style! It's seems an extreme story. And I *believe* anywhere written that Pg requires some version of C standard. regards, -- Kyotaro Horiguchi NTT Open Source Software Center
Hello, At Thu, 17 Nov 2016 11:59:02 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20161117.115902.224922490.horiguchi.kyotaro@lab.ntt.co.jp> > My only concern is the fact that 'make check-world' runs the TAP > tests as a part if --enable-tap-tests (according to > release-9.4.sgml, but I haven't done by myself.). I completely > agree to you if it didn't run as a part of top-level 'make <some > kind of check>'. Hmm. I notice that older perls may reject installation of TAP. If that's true, no check needed but a description also might be needed to --enable-tap-tests. Or, might not be needed since anyway it fails for the older versions. diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml index 296611d..58459e5 100644 --- a/doc/src/sgml/installation.sgml +++ b/doc/src/sgml/installation.sgml @@ -1285,9 +1285,11 @@ su - postgres <term><option>--enable-tap-tests</option></term> <listitem> <para> - Enable tests using the Perl TAP tools. This requires a Perl - installation and the Perl module <literal>IPC::Run</literal>. - <![%standalone-ignore;[See <xref linkend="regress-tap"> for more information.]]> + Enable tests using the Perl TAP tools. This requires a Perl (5.8.8 + or later) installation and the Perl + module <literal>IPC::Run</literal>. + <![%standalone-ignore;[See <xref linkend="regress-tap"> for more + information.]]> </para> </listitem> </varlistentry> regards, -- Kyotaro Horiguchi NTT Open Source Software Center
On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer <craig@2ndquadrant.com> wrote: > In all seriousness, though, lets query the buildfarm database for Perl > versions. Let it answer. castoroides, Solaris 10 and perl 5.8.4, no? https://www.postgresql.org/message-id/20150415053842.GA2948387@tornado.leadboat.com -- Michael
On 17 November 2016 at 12:23, Michael Paquier <michael.paquier@gmail.com> wrote: > On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer <craig@2ndquadrant.com> wrote: >> In all seriousness, though, lets query the buildfarm database for Perl >> versions. Let it answer. > > castoroides, Solaris 10 and perl 5.8.4, no? > https://www.postgresql.org/message-id/20150415053842.GA2948387@tornado.leadboat.com Thanks for checking. Can we just add the README text with Perl 5.8.4 then? Or 5.8.0 or 3.005 or whatever version is determined to be the oldest needed? -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer <craig@2ndquadrant.com> wrote: > On 17 November 2016 at 10:42, Craig Ringer <craig@2ndquadrant.com> wrote: >> But sure, if it's easier, we can have 5.8.0 in the README. What's five >> extra years matter anyway? Hey, while we're at it, lets change Pg to >> build on Borland C and require K&R style! > > Sorry. That was unnecessary. I should've had the sense to save that as > a draft and come back later. Well, *I* thought it was pretty funny... I remember K&R style rather fondly. Of course it was inferior technically, but if you could get things to compile that way you could feel like a wizard for being able to make the old compiler work. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 18 November 2016 at 05:41, Robert Haas <robertmhaas@gmail.com> wrote: > On Wed, Nov 16, 2016 at 9:54 PM, Craig Ringer <craig@2ndquadrant.com> wrote: >> On 17 November 2016 at 10:42, Craig Ringer <craig@2ndquadrant.com> wrote: >>> But sure, if it's easier, we can have 5.8.0 in the README. What's five >>> extra years matter anyway? Hey, while we're at it, lets change Pg to >>> build on Borland C and require K&R style! >> >> Sorry. That was unnecessary. I should've had the sense to save that as >> a draft and come back later. > > Well, *I* thought it was pretty funny... > > I remember K&R style rather fondly. Of course it was inferior > technically, but if you could get things to compile that way you could > feel like a wizard for being able to make the old compiler work. Rather. I remember getting modern software to compile on SCO OpenServer 5.0.5 that way. *Twich* *twitch*. Anyway, here's an updated patch with version changed to 5.8.4 since that's the newest we test on the buildfarm (and it's from 2004). I wasted a bunch of time getting set up to test for such an ancient Perl and would love to save the next person along the hassle by documenting the easy way. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Вложения
On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <craig@2ndquadrant.com> wrote: > I wasted a bunch of time getting set up to test for such an ancient > Perl and would love to save the next person along the hassle by > documenting the easy way. It looks sensible to mention that in the README, so +1. By the way, would it matter to mention ways to install perlbrew? For example, I just bumped into http://install.perlbrew.pl by looking around, though I don't doubt that most people would just use cpan with "install App::perlbrew" for example. For OSX users with brew and without macports that would matter. -- Michael
On 18 November 2016 at 07:10, Michael Paquier <michael.paquier@gmail.com> wrote: > On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <craig@2ndquadrant.com> wrote: >> I wasted a bunch of time getting set up to test for such an ancient >> Perl and would love to save the next person along the hassle by >> documenting the easy way. > > It looks sensible to mention that in the README, so +1. > > By the way, would it matter to mention ways to install perlbrew? For > example, I just bumped into http://install.perlbrew.pl by looking > around, though I don't doubt that most people would just use cpan with > "install App::perlbrew" for example. For OSX users with brew and > without macports that would matter. The docs linked mention it, so I figured that'd probably do. Though I notice it's only mentioned in the "configuration" section not under "installation", so maybe it's worth adding yeah. -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services
On 18 November 2016 at 08:15, Craig Ringer <craig@2ndquadrant.com> wrote: > On 18 November 2016 at 07:10, Michael Paquier <michael.paquier@gmail.com> wrote: >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <craig@2ndquadrant.com> wrote: >>> I wasted a bunch of time getting set up to test for such an ancient >>> Perl and would love to save the next person along the hassle by >>> documenting the easy way. >> >> It looks sensible to mention that in the README, so +1. >> >> By the way, would it matter to mention ways to install perlbrew? For >> example, I just bumped into http://install.perlbrew.pl by looking >> around, though I don't doubt that most people would just use cpan with >> "install App::perlbrew" for example. For OSX users with brew and >> without macports that would matter. > > The docs linked mention it, so I figured that'd probably do. Though I > notice it's only mentioned in the "configuration" section not under > "installation", so maybe it's worth adding yeah. Updated docs patch. Since configure checks for 5.8.0 that's what's specified. Anyone who wants to argue about the actual version we _should_ target can do so elsewhere, all I'm interested in is what we _do_ officially target so I can document this. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Вложения
Hello, At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer <craig@2ndquadrant.com> wrote in <CAMsr+YHdiEMRB+2yBz=xaxBX5qTeB73nN1QS5dy4BUdT_W3csg@mail.gmail.com> > On 18 November 2016 at 08:15, Craig Ringer <craig@2ndquadrant.com> wrote: > > On 18 November 2016 at 07:10, Michael Paquier <michael.paquier@gmail.com> wrote: > >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <craig@2ndquadrant.com> wrote: > >>> I wasted a bunch of time getting set up to test for such an ancient > >>> Perl and would love to save the next person along the hassle by > >>> documenting the easy way. > >> > >> It looks sensible to mention that in the README, so +1. I appreciate the labor. Anyway I don't object for adding that to the README. +1. > >> By the way, would it matter to mention ways to install perlbrew? For > >> example, I just bumped into http://install.perlbrew.pl by looking > >> around, though I don't doubt that most people would just use cpan with > >> "install App::perlbrew" for example. For OSX users with brew and > >> without macports that would matter. > > > > The docs linked mention it, so I figured that'd probably do. Though I > > notice it's only mentioned in the "configuration" section not under > > "installation", so maybe it's worth adding yeah. > > Updated docs patch. Since configure checks for 5.8.0 that's what's > specified. Anyone who wants to argue about the actual version we > _should_ target can do so elsewhere, all I'm interested in is what we > _do_ officially target so I can document this. I understand you :p By the way, the new doc points to http://install.perlbrew.pl and it just shows the install script. It seems more puzzling.. I suppose https://perlbrew.pl/ seems to me the primary site for perbrew. | Perlbrew | | perlbrew is an admin-free perl installation management tool. The latest version is 0.78, read the release note: Release0.78. | | Install, quickly | | Copy & Paste this line into your terminal: | | \curl -L https://install.perlbrew.pl | bash regards, -- Kyotaro Horiguchi NTT Open Source Software Center
On 21 November 2016 at 12:23, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote: > Hello, > > At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer <craig@2ndquadrant.com> wrote in <CAMsr+YHdiEMRB+2yBz=xaxBX5qTeB73nN1QS5dy4BUdT_W3csg@mail.gmail.com> >> On 18 November 2016 at 08:15, Craig Ringer <craig@2ndquadrant.com> wrote: >> > On 18 November 2016 at 07:10, Michael Paquier <michael.paquier@gmail.com> wrote: >> >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <craig@2ndquadrant.com> wrote: >> >>> I wasted a bunch of time getting set up to test for such an ancient >> >>> Perl and would love to save the next person along the hassle by >> >>> documenting the easy way. >> >> >> >> It looks sensible to mention that in the README, so +1. > > I appreciate the labor. Anyway I don't object for adding that to > the README. +1. Thanks. > I understand you :p By the way, the new doc points to > http://install.perlbrew.pl and it just shows the install > script. It seems more puzzling.. > > I suppose https://perlbrew.pl/ seems to me the primary site for > perbrew. Oops! Fixed in attached. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Вложения
On Mon, Nov 21, 2016 at 3:38 PM, Craig Ringer <craig@2ndquadrant.com> wrote: > On 21 November 2016 at 12:23, Kyotaro HORIGUCHI > <horiguchi.kyotaro@lab.ntt.co.jp> wrote: >> I understand you :p By the way, the new doc points to >> http://install.perlbrew.pl and it just shows the install >> script. It seems more puzzling.. >> >> I suppose https://perlbrew.pl/ seems to me the primary site for >> perbrew. > > Oops! > > Fixed in attached. No objections to this version. It's a good idea to document that. -- Michael
At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in <CAB7nPqTuNtqkxPvk38ZP6HKRX6XdL62SPPfRas5P-S-d_Kt2iA@mail.gmail.com> > > Fixed in attached. > > No objections to this version. It's a good idea to document that. +1 regards, -- Kyotaro Horiguchi NTT Open Source Software Center
On Mon, Nov 21, 2016 at 11:58:34AM +0800, Craig Ringer wrote: > Updated docs patch. Since configure checks for 5.8.0 that's what's > specified. Anyone who wants to argue about the actual version we > _should_ target can do so elsewhere, all I'm interested in is what we > _do_ officially target so I can document this. That's a proper separation of efforts; thanks. On Mon, Nov 21, 2016 at 05:37:50PM +0900, Kyotaro HORIGUCHI wrote: > At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in <CAB7nPqTuNtqkxPvk38ZP6HKRX6XdL62SPPfRas5P-S-d_Kt2iA@mail.gmail.com> > > No objections to this version. It's a good idea to document that. > > +1 Committed after re-filling paragraphs.
On Sun, Dec 4, 2016 at 2:28 PM, Noah Misch <noah@leadboat.com> wrote: > Committed after re-filling paragraphs. Thanks, I have updated the CF entry as well. -- Michael
Re: Document how to set up TAP tests for Perl 5.8.8
От
ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Дата:
Noah Misch <noah@leadboat.com> writes: > On Mon, Nov 21, 2016 at 05:37:50PM +0900, Kyotaro HORIGUCHI wrote: >> At Mon, 21 Nov 2016 16:45:10 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in <CAB7nPqTuNtqkxPvk38ZP6HKRX6XdL62SPPfRas5P-S-d_Kt2iA@mail.gmail.com> >> > No objections to this version. It's a good idea to document that. >> >> +1 > > Committed after re-filling paragraphs. I just noticed this bit in the committed patch: + cpanm install IPC::Run This is not the correct invocation of cpanm: it just takes a list of module names. This will pull in the 'install' module, which is harmless, but unnecessary: https://metacpan.org/pod/install. -- "I use RMS as a guide in the same way that a boat captain would usea lighthouse. It's good to know where it is, but yougenerallydon't want to find yourself in the same spot." - Tollef Fog Heen
On 5 December 2016 at 19:17, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote: > This is not the correct invocation of cpanm: it just takes a list of > module names. This will pull in the 'install' module, which is > harmless, but unnecessary: https://metacpan.org/pod/install. Ha. Good catch. Since, as you noted, it's harmless I didn't realise it'd happened. -- Craig Ringer http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services