Обсуждение: Re: [HACKERS] [COMMITTERS] pgsql: Check interrupts during hot standby waits

Поиск
Список
Период
Сортировка

Re: [HACKERS] [COMMITTERS] pgsql: Check interrupts during hot standby waits

От
Andres Freund
Дата:
Hi,

On 2017-01-26 19:00:34 +0000, Simon Riggs wrote:
> Check interrupts during hot standby waits
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec
>
> Modified Files
> --------------
> src/backend/storage/ipc/standby.c | 2 ++
> 1 file changed, 2 insertions(+)

It seems that the actual fix here would be to replace the pg_usleep loop
with a latch wait.... Then we also don't need to needlessly loop, and
actually react promptly to signals.

Andres



Re: [HACKERS] [COMMITTERS] pgsql: Check interrupts during hot standby waits

От
Michael Paquier
Дата:
On Fri, Jan 27, 2017 at 4:06 AM, Andres Freund <andres@anarazel.de> wrote:
> Hi,
>
> On 2017-01-26 19:00:34 +0000, Simon Riggs wrote:
>> Check interrupts during hot standby waits
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec
>>
>> Modified Files
>> --------------
>> src/backend/storage/ipc/standby.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> It seems that the actual fix here would be to replace the pg_usleep loop
> with a latch wait.... Then we also don't need to needlessly loop, and
> actually react promptly to signals.

For the record, a patch has been posted on the original thread:
https://www.postgresql.org/message-id/CAB7nPqRNcd+FR=8_Lyb65jBcRPX+59hXobi5G-wf4fxRak_6gw@mail.gmail.com
-- 
Michael