Обсуждение: [pgadmin-hackers] connection error

Поиск
Список
Период
Сортировка

[pgadmin-hackers] connection error

От
George Gelashvili
Дата:
Hi Hackers!

Our tests found a bug with the current version of master, that was introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
It is throwing an error when the server starts up and returns an error message of None, and thereby breaking the happy path. There is a function ('create' around line 587) in servers/__init__.py that checks against the attribute 'decode', which the server doesn't have when there isn't an error message.

George & Sarah
Вложения

Re: [pgadmin-hackers] connection error

От
George Gelashvili
Дата:
aaaand here's a patch

On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili <ggelashvili@pivotal.io> wrote:
Hi Hackers!

Our tests found a bug with the current version of master, that was introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
It is throwing an error when the server starts up and returns an error message of None, and thereby breaking the happy path. There is a function ('create' around line 587) in servers/__init__.py that checks against the attribute 'decode', which the server doesn't have when there isn't an error message.

George & Sarah

Вложения

Re: [pgadmin-hackers] connection error

От
Dave Page
Дата:
Thanks, applied.

On Thu, Feb 16, 2017 at 4:31 PM, George Gelashvili
<ggelashvili@pivotal.io> wrote:
> aaaand here's a patch
>
> On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili <ggelashvili@pivotal.io>
> wrote:
>>
>> Hi Hackers!
>>
>> Our tests found a bug with the current version of master, that was
>> introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
>> It is throwing an error when the server starts up and returns an error
>> message of None, and thereby breaking the happy path. There is a function
>> ('create' around line 587) in servers/__init__.py that checks against the
>> attribute 'decode', which the server doesn't have when there isn't an error
>> message.
>>
>> George & Sarah
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company