Обсуждение: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issues with CSV file download

Hi,

Please find the patch to fix the issues in CSV file download feature,

1) To handle non-ascii filenames which we set from table name

RM#2314

2) To handle non-ascii query data

RM#2353

3) To dump JSON type columns properly in csv

RM#2360

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Thanks, patch applied.

On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find the patch to fix the issues in CSV file download feature,

1) To handle non-ascii filenames which we set from table name

RM#2314

2) To handle non-ascii query data

RM#2353

3) To dump JSON type columns properly in csv

RM#2360

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi Dave,

Please find patch to handle non-ascii column names in CSV for Pyhton2.

Thanks to Harshal for pointing out the issue.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 8, 2017 at 6:06 PM, Dave Page <dpage@pgadmin.org> wrote:

Thanks, patch applied.

On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

Please find the patch to fix the issues in CSV file download feature,

1) To handle non-ascii filenames which we set from table name

RM#2314

2) To handle non-ascii query data

RM#2353

3) To dump JSON type columns properly in csv

RM#2360

Please review.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company