Обсуждение: [pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary keyorder when view data

Поиск
Список
Период
Сортировка

[pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary keyorder when view data

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix the issue in table node, 
1) In 'UPDATE Script', '?' is missing with last column. 
2) If there are multiple primary keys in table then the order of columns is incorrect in view data ORDER BY clause.
RM#2417

Also fixed minor issue in Materialized view which I found during testing, we were not passing database id in properties.sql which is required for Select and Insert script to work.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATEScript and Primary key order when view data

От
Dave Page
Дата:
Thanks, patch applied (and bugs created for the other two issues).

On Fri, May 26, 2017 at 6:12 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in table node,
> 1) In 'UPDATE Script', '?' is missing with last column.
> 2) If there are multiple primary keys in table then the order of columns is
> incorrect in view data ORDER BY clause.
> RM#2417
>
> Also fixed minor issue in Materialized view which I found during testing, we
> were not passing database id in properties.sql which is required for Select
> and Insert script to work.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company