Обсуждение: [pgAdmin4][Patch]: Using client-side 'url_for' implementation inSqleditor module

Поиск
Список
Период
Сортировка

[pgAdmin4][Patch]: Using client-side 'url_for' implementation inSqleditor module

От
Surinder Kumar
Дата:
Hi

Changes:

1. Replace Jinja {{ url_for }} with js 'url_for'

2. While minifying JS using webpack, I got couple of errors(variables undefined) in browser for generated sqleditor.js, so declared those variables before using them. 

Please find attached patch.

Thanks,
Surinder Kumar
Вложения

Re: [pgAdmin4][Patch]: Using client-side 'url_for' implementation inSqleditor module

От
Dave Page
Дата:
Thanks, patch applied.

On Mon, Jun 26, 2017 at 2:45 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Changes:
>
> 1. Replace Jinja {{ url_for }} with js 'url_for'
>
> 2. While minifying JS using webpack, I got couple of errors(variables
> undefined) in browser for generated sqleditor.js, so declared those
> variables before using them.
>
> Please find attached patch.
>
> Thanks,
> Surinder Kumar



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company