Обсуждение: [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()
Hi, I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg(). This says "Compute ID and segment from an XLogRecPtr", but these macros compute only segment numbers. I think "Compute a segment number from an XLogRecPtr" is correct. The definition of these macros were modified by the following commit, but the comment were not. commit dfda6ebaec6763090fb78b458a979b558c50b39b Author: Heikki Linnakangas <heikki.linnakangas@iki.fi> Date: Sun Jun 24 18:06:38 2012 +0300 Regards, -- Yugo Nagata <nagata@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Вложения
> I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg(). > This says "Compute ID and segment from an XLogRecPtr", but these > macros compute only segment numbers. I think "Compute a segment number > from an XLogRecPtr" is correct. > > The definition of these macros were modified by the following commit, > but the comment were not. > > commit dfda6ebaec6763090fb78b458a979b558c50b39b > Author: Heikki Linnakangas <heikki.linnakangas@iki.fi> > Date: Sun Jun 24 18:06:38 2012 +0300 Thanks for the patch. Looks good to me. I will commit/push into all supported branches if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
> Thanks for the patch. Looks good to me. I will commit/push into all > supported branches if there's no objection. Done. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
On Tue, 01 Aug 2017 08:11:23 +0900 (JST) Tatsuo Ishii <ishii@sraoss.co.jp> wrote: > > Thanks for the patch. Looks good to me. I will commit/push into all > > supported branches if there's no objection. > > Done. Thanks! > > Best regards, > -- > Tatsuo Ishii > SRA OSS, Inc. Japan > English: http://www.sraoss.co.jp/index_en.php > Japanese:http://www.sraoss.co.jp > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Yugo Nagata <nagata@sraoss.co.jp>