Обсуждение: [pgAdmin4][RM#3175] Fix PEP-8 issues

Поиск
Список
Период
Сортировка

[pgAdmin4][RM#3175] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Hi,

PFA patch to fix PEP8 issues in Browser & Database modules, 
pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/tests/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Вложения

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

От
Joao De Almeida Pereira
Дата:
Hi Murtuza,

Looks good, and all tests are green. I run the commands provided and nothing pops up.

Only missing 374 :D

Thanks
Joao

On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix PEP8 issues in Browser & Database modules, 
pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/tests/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

От
Murtuza Zabuawala
Дата:
Thanks Joao for reviewing.


On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,

Looks good, and all tests are green. I run the commands provided and nothing pops up.

Only missing 374 :D
​:-) ​
 

Thanks
Joao

On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix PEP8 issues in Browser & Database modules, 
pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/tests/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

От
Dave Page
Дата:
Thanks, applied!

On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thanks Joao for reviewing.


On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,

Looks good, and all tests are green. I run the commands provided and nothing pops up.

Only missing 374 :D
​:-) ​
 

Thanks
Joao

On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix PEP8 issues in Browser & Database modules, 
pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/tests/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company