Обсуждение: [pgAdmin4][RM#3175] Fix PEP-8 issues
Hi,
PFA patch to fix PEP8 issues in Browser & Database modules,
pycodestyle --config=.pycodestyle pgadmin/browser/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/tests/
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py
pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/
--
Regards,
Вложения
Hi Murtuza,
Looks good, and all tests are green. I run the commands provided and nothing pops up.
Only missing 374 :D
Thanks
Joao
On Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to fix PEP8 issues in Browser & Database modules,pycodestyle --config=.pycodestyle pgadmin/browser/__init__.pypycodestyle --config=.pycodestyle pgadmin/browser/tests/pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.pypycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/--Regards,
Thanks Joao for reviewing.
On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,Looks good, and all tests are green. I run the commands provided and nothing pops up.Only missing 374 :D
:-)
ThanksJoaoOn Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix PEP8 issues in Browser & Database modules,pycodestyle --config=.pycodestyle pgadmin/browser/__init__.pypycodestyle --config=.pycodestyle pgadmin/browser/tests/pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/ --Regards,
Thanks, applied!
On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thanks Joao for reviewing.On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:Hi Murtuza,Looks good, and all tests are green. I run the commands provided and nothing pops up.Only missing 374 :D:-) ThanksJoaoOn Mon, Mar 5, 2018 at 7:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: Hi,PFA patch to fix PEP8 issues in Browser & Database modules,pycodestyle --config=.pycodestyle pgadmin/browser/__init__.pypycodestyle --config=.pycodestyle pgadmin/browser/tests/pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/__init__.py pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/servers/databases/tests/ --Regards,
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company