Обсуждение: Source packages for pgl_ddl_deploy

Поиск
Список
Период
Сортировка

Source packages for pgl_ddl_deploy

От
Jeremy Finzel
Дата:
Dear Christoph,

Forever ago, I asked about sharing packages for pgl_ddl_deploy, an extension we wanted to share on PGDG.  You asked for me to provide source packages, and we have only just been able to do this.  We are now on version 1.2.0.  FYI again here is the git repo: https://github.com/enova/pgl_ddl_deploy

I have attached the source packages.  Please let me know if this gives us what we need to share this extension with the community or if you need more from us.  I sure appreciate your help!

Thanks,
Jeremy
Вложения

Re: Source packages for pgl_ddl_deploy

От
Christoph Berg
Дата:
Re: Jeremy Finzel 2018-03-16 <CAMa1XUi1piCwj9B1hKtUM5wRGAekMwuNXHSO6zfC80aW6bQ36w@mail.gmail.com>
> Dear Christoph,
> 
> Forever ago, I asked about sharing packages for pgl_ddl_deploy, an
> extension we wanted to share on PGDG.  You asked for me to provide source
> packages, and we have only just been able to do this.  We are now on
> version 1.2.0.  FYI again here is the git repo:
> https://github.com/enova/pgl_ddl_deploy
> 
> I have attached the source packages.  Please let me know if this gives us
> what we need to share this extension with the community or if you need more
> from us.  I sure appreciate your help!

Hi Jeremy,

I'm sorry I didn't get around to reply earlier - I had still flagged
your old mail in my inbox, but it didn't happen.

The extension packaging seems almost perfect. The only change I had to
do to get it pass the testsuite on PG 10 was to make it actually load
pglogical in debian/tests/installcheck:

#!/bin/sh
pg_buildext -o shared_preload_libraries=pglogical installcheck

(The needed pglogical packages have not yet been released on apt.pg.o,
but there's prereleases in the *-pgdg-testing distributions there.)

For building the packages on apt.postgresql.org, we'd need a place to
actually pull the source (package) from. Ideally, you would just add
the Debian directory to git, either to master, or in a separate debian
branch only. For the tarball, make a release on github (pushing a tag
with a sensible name is enough), and add a debian/watch file, e.g.:

version=4
https://github.com/enova/pgl_ddl_deploy/releases .*/v(.*)\.tar\.gz

That way our build machinery can automatically grab the .tar.gz from
github using "uscan" (and also notify about new releases being made).

I like it if the apt.pg.o packages are also uploaded to Debian. Would
you be ok if I uploaded the package there? (With you being listed as
Maintainer in debian/control?)

Christoph


Re: Source packages for pgl_ddl_deploy

От
Jeremy Finzel
Дата:
Dear Christoph,

Sorry for the delay - we have released one more patch along with the required changes you suggested for this to be fully ready for packaging.  See below.
 
The extension packaging seems almost perfect. The only change I had to
do to get it pass the testsuite on PG 10 was to make it actually load
pglogical in debian/tests/installcheck:

#!/bin/sh
pg_buildext -o shared_preload_libraries=pglogical installcheck

(The needed pglogical packages have not yet been released on apt.pg.o,
but there's prereleases in the *-pgdg-testing distributions there.)

For building the packages on apt.postgresql.org, we'd need a place to
actually pull the source (package) from. Ideally, you would just add
the Debian directory to git, either to master, or in a separate debian
branch only. For the tarball, make a release on github (pushing a tag
with a sensible name is enough), and add a debian/watch file, e.g.:
version=4
https://github.com/enova/pgl_ddl_deploy/releases .*/v(.*)\.tar\.gz
That way our build machinery can automatically grab the .tar.gz from
github using "uscan" (and also notify about new releases being made).

I like it if the apt.pg.o packages are also uploaded to Debian. Would
you be ok if I uploaded the package there? (With you being listed as
Maintainer in debian/control?)

Christoph

This has now been done and is ready at https://github.com/enova/pgl_ddl_deploy/tree/master/debian

I just tagged the most recent release as you suggested: https://github.com/enova/pgl_ddl_deploy/releases/tag/v1.3.0

Yes, it is OK to upload the packages to Debian as you asked.

Please let me know if this gives us what we need.

Thanks very much!
Jeremy

Re: Source packages for pgl_ddl_deploy

От
Christoph Berg
Дата:
Re: Jeremy Finzel 2018-04-11 <CAMa1XUiDJv6-1przVS2DCD5ZqvT1GYFrNEuqw2srzVc2wk2=zQ@mail.gmail.com>
> This has now been done and is ready at
> https://github.com/enova/pgl_ddl_deploy/tree/master/debian
> 
> I just tagged the most recent release as you suggested:
> https://github.com/enova/pgl_ddl_deploy/releases/tag/v1.3.0

Hi,

debian/changelog is still at 1.2, could you fix that? (No need to
re-tag.)

> Yes, it is OK to upload the packages to Debian as you asked.

Will do once the changelog is fixed.

Christoph


Re: Source packages for pgl_ddl_deploy

От
"Salvador, Dominic"
Дата:
Hey,

Changelog is fixed.  However, I need someone from Enova to merge the pull request.



Thanks,
Dominic Salvador
System Engineer
IT Infrastructure Services
Office: +1 312-568-4200 x5492
Mobile: +1 847-420-6596

On Thu, Apr 12, 2018 at 3:15 AM, Christoph Berg <myon@debian.org> wrote:
Re: Jeremy Finzel 2018-04-11 <CAMa1XUiDJv6-1przVS2DCD5ZqvT1GYFrNEuqw2srzVc2wk2=zQ@mail.gmail.com>
> This has now been done and is ready at
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_enova_pgl-5Fddl-5Fdeploy_tree_master_debian&d=DwIBAg&c=lEzKI_JJakPtcnbAQ6Q5xQ&r=fkTvtLogD0__1bv85GwXVKwPVr8BZEiGjAENgezb-Ms&m=wOt1Vhgl1_NqSZmMIo7MzmA16Nr8KmKx3i3EvPz3nHg&s=htDv4voI7qtcqyfRVci6mMgF7qMrHE7WTdBL7bkyyOY&e=
>
> I just tagged the most recent release as you suggested:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_enova_pgl-5Fddl-5Fdeploy_releases_tag_v1.3.0&d=DwIBAg&c=lEzKI_JJakPtcnbAQ6Q5xQ&r=fkTvtLogD0__1bv85GwXVKwPVr8BZEiGjAENgezb-Ms&m=wOt1Vhgl1_NqSZmMIo7MzmA16Nr8KmKx3i3EvPz3nHg&s=QYnf8fPgnlf9cQZtR7k4m6D3qhZpdwdHTxMqNMVJH0c&e=

Hi,

debian/changelog is still at 1.2, could you fix that? (No need to
re-tag.)

> Yes, it is OK to upload the packages to Debian as you asked.

Will do once the changelog is fixed.

Christoph

Re: Source packages for pgl_ddl_deploy

От
Christoph Berg
Дата:
Re: Salvador, Dominic 2018-04-17 <CABr3=_e_uqXHQ878Z6McMVsaCM+Roz9=d7axdKm3iqWyqUqT2Q@mail.gmail.com>
> Hey,
> 
> Changelog is fixed.  However, I need someone from Enova to merge the pull
> request.

Hi,

looks good now, I'm just building the packages for apt.postgresql.org.

I created a pull request and an issue, but these can wait for the next
release.

Cheers,
Christoph