Обсуждение: pg_basebackup -k option
The new pg_basebackup -k option stands for --no-verify-checksums. That is nearly the opposite of initdb -k, which is for enabling checksums. I think it could be confusing to have two related tools use the same option letter for nearly opposite purposes. How about using capital -K in pg_basebackup? Or maybe it doesn't need a short option at all. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Hi I think having only long option is enough regards, Sergei
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> The new pg_basebackup -k option stands for --no-verify-checksums. That
> is nearly the opposite of initdb -k, which is for enabling checksums. I
> think it could be confusing to have two related tools use the same
> option letter for nearly opposite purposes.
> How about using capital -K in pg_basebackup? Or maybe it doesn't need a
> short option at all.
+1 for no short option.
regards, tom lane
Hi, On Fri, May 18, 2018 at 10:46:37AM -0400, Tom Lane wrote: > Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes: > > The new pg_basebackup -k option stands for --no-verify-checksums. That > > is nearly the opposite of initdb -k, which is for enabling checksums. I > > think it could be confusing to have two related tools use the same > > option letter for nearly opposite purposes. > > > How about using capital -K in pg_basebackup? Or maybe it doesn't need a > > short option at all. > > +1 for no short option. Makes sense to me, I wasn't happy about the -k back then (and I think I solicited feedback on that). PFA a patch which should remove the short option. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Вложения
On Fri, May 18, 2018 at 4:46 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> The new pg_basebackup -k option stands for --no-verify-checksums. That
> is nearly the opposite of initdb -k, which is for enabling checksums. I
> think it could be confusing to have two related tools use the same
> option letter for nearly opposite purposes.
> How about using capital -K in pg_basebackup? Or maybe it doesn't need a
> short option at all.
+1 for no short option.
+1 for that choice as well.
On 5/18/18 11:26, Michael Banck wrote: >>> How about using capital -K in pg_basebackup? Or maybe it doesn't need a >>> short option at all. >> >> +1 for no short option. > > Makes sense to me, I wasn't happy about the -k back then (and I think I > solicited feedback on that). > > PFA a patch which should remove the short option. committed (needed test and documentation adjustments, too) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services