Обсуждение: [pgAdmin4][RM3514] Bullets and tooltips for charts

Поиск
Список
Период
Сортировка

[pgAdmin4][RM3514] Bullets and tooltips for charts

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to:
1) Add bullets and tooltips to dashboard graphs. Can be enabled/disabled from Preferences -> Dashboards -> Display.
2) Fixes RM3516 - Closing the Dashboard tab no longer stops the queries being executed.
3) Separated charting library Flotr2 from dashboard. Possible test cases added.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Вложения

Re: [pgAdmin4][RM3514] Bullets and tooltips for charts

От
Dave Page
Дата:
Thanks - patch applied.

However, I realised as I hit push that there was no doc update for the Preferences panel. Can you send that and any updated screenshots please?

Thanks!

On Wed, Sep 5, 2018 at 2:42 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Add bullets and tooltips to dashboard graphs. Can be enabled/disabled from Preferences -> Dashboards -> Display.
2) Fixes RM3516 - Closing the Dashboard tab no longer stops the queries being executed.
3) Separated charting library Flotr2 from dashboard. Possible test cases added.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3514] Bullets and tooltips for charts

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch for doc and screenshot updates.
Kindly review.

On Wed, Sep 5, 2018 at 9:56 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

However, I realised as I hit push that there was no doc update for the Preferences panel. Can you send that and any updated screenshots please?

Thanks!

On Wed, Sep 5, 2018 at 2:42 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Add bullets and tooltips to dashboard graphs. Can be enabled/disabled from Preferences -> Dashboards -> Display.
2) Fixes RM3516 - Closing the Dashboard tab no longer stops the queries being executed.
3) Separated charting library Flotr2 from dashboard. Possible test cases added.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Вложения

Re: [pgAdmin4][RM3514] Bullets and tooltips for charts

От
Dave Page
Дата:
Thanks!

On Thu, Sep 6, 2018 at 9:50 AM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for doc and screenshot updates.
Kindly review.

On Wed, Sep 5, 2018 at 9:56 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied.

However, I realised as I hit push that there was no doc update for the Preferences panel. Can you send that and any updated screenshots please?

Thanks!

On Wed, Sep 5, 2018 at 2:42 PM, Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to:
1) Add bullets and tooltips to dashboard graphs. Can be enabled/disabled from Preferences -> Dashboards -> Display.
2) Fixes RM3516 - Closing the Dashboard tab no longer stops the queries being executed.
3) Separated charting library Flotr2 from dashboard. Possible test cases added.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company