Обсуждение: pgsql: Build src/common files as a library with -fPIC.

Поиск
Список
Период
Сортировка

pgsql: Build src/common files as a library with -fPIC.

От
Tom Lane
Дата:
Build src/common files as a library with -fPIC.

Build a third version of libpgcommon.a, with -fPIC and -DFRONTEND,
as commit ea53100d5 did for src/port.  Use that in libpq to avoid
symlinking+rebuilding source files retail.

Also adjust ecpg to use the new src/port and src/common libraries.

Arrange to install these libraries, too, to simplify out-of-tree
builds of shared libraries that need any of these modules.

Discussion: https://postgr.es/m/13022.1538003440@sss.pgh.pa.us
Discussion: https://postgr.es/m/E1g5Y8r-0006vs-QA@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7143b3e82136d2941b3394168940d895a29b4f36

Modified Files
--------------
src/Makefile.global.in                    | 15 ++++++----
src/common/Makefile                       | 48 ++++++++++++++++++++++++-------
src/interfaces/ecpg/compatlib/.gitignore  |  4 ---
src/interfaces/ecpg/compatlib/Makefile    | 13 ++-------
src/interfaces/ecpg/ecpglib/.gitignore    |  9 ------
src/interfaces/ecpg/ecpglib/Makefile      | 27 +++--------------
src/interfaces/ecpg/pgtypeslib/.gitignore |  7 -----
src/interfaces/ecpg/pgtypeslib/Makefile   | 20 ++-----------
src/interfaces/libpq/.gitignore           |  9 ------
src/interfaces/libpq/Makefile             | 22 ++++++--------
src/port/Makefile                         |  5 ++--
11 files changed, 68 insertions(+), 111 deletions(-)


Re: pgsql: Build src/common files as a library with -fPIC.

От
Andres Freund
Дата:
On 2018-09-28 18:28:30 +0000, Tom Lane wrote:
> Build src/common files as a library with -fPIC.
> 
> Build a third version of libpgcommon.a, with -fPIC and -DFRONTEND,
> as commit ea53100d5 did for src/port.  Use that in libpq to avoid
> symlinking+rebuilding source files retail.
> 
> Also adjust ecpg to use the new src/port and src/common libraries.
> 
> Arrange to install these libraries, too, to simplify out-of-tree
> builds of shared libraries that need any of these modules.
> 
> Discussion: https://postgr.es/m/13022.1538003440@sss.pgh.pa.us
> Discussion: https://postgr.es/m/E1g5Y8r-0006vs-QA@gemulon.postgresql.org

I assume you noticed
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=woodlouse&dt=2018-09-28%2018%3A42%3A53
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2018-09-28%2018%3A30%3A25

Looks like Mkvcbuild.pm needs some tweaking, too.

Greetings,

Andres Freund


Re: pgsql: Build src/common files as a library with -fPIC.

От
Tom Lane
Дата:
Andres Freund <andres@anarazel.de> writes:
> Looks like Mkvcbuild.pm needs some tweaking, too.

Yeah, I was kinda surprised that the first round of changes didn't
seem to require anything there.  I'll take a look.

            regards, tom lane