Обсуждение: pgsql: Fix copy-paste error in errhint() introduced in 691d79a07933.
Fix copy-paste error in errhint() introduced in 691d79a07933. Reported-By: Petr Jelinek Discussion: https://postgr.es/m/c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com Backpatch: 9.4-, like the previous commit Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a3fb382e9c166e398763e3bbf706b6c92a647fe1 Modified Files -------------- src/backend/replication/slot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: Andres Freund 2018-11-05 <E1gJlBt-0005mL-45@gemulon.postgresql.org> > Fix copy-paste error in errhint() introduced in 691d79a07933. > > Reported-By: Petr Jelinek > Discussion: https://postgr.es/m/c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com > Backpatch: 9.4-, like the previous commit - errhint("Change wal_level to be replica or higher."))); + errhint("Change wal_level to be logical or higher."))); Are there wal_levels higher than logical? Christoph
Hi, On 2018-11-07 22:32:22 +0100, Christoph Berg wrote: > Re: Andres Freund 2018-11-05 <E1gJlBt-0005mL-45@gemulon.postgresql.org> > > Fix copy-paste error in errhint() introduced in 691d79a07933. > > > > Reported-By: Petr Jelinek > > Discussion: https://postgr.es/m/c95a620b-34f0-7930-aeb5-f7ab804f26cb@2ndquadrant.com > > Backpatch: 9.4-, like the previous commit > > - errhint("Change wal_level to be replica or higher."))); > + errhint("Change wal_level to be logical or higher."))); > > Are there wal_levels higher than logical? Not right now, but it seems quite likely that there will be. IIRC we've phrased a few other messages like that. It's quite likely that otherwise the message would be forgotten to be updated. And it's not like it's incorrect. Greetings, Andres Freund