Обсуждение: NULL handling in exconfig deconstruction

In extension_config_remove() we first ensure that pg_extension.extconfig cannot
contain any NULL values in the array, ERRORing out if so.  Later we however ask
for NULL values back when deconstructing the array, throwing away the results
knowing there wont be any, which seems superfluous (and wrong if there indeed
were any).  The attached patch signals to deconstruct_array() that any NULL
values should be considered an error instead of returned, to keep NULL value
handling consistent (and shave two small allocations off).

cheers ./daniel

Daniel Gustafsson <daniel@yesql.se> writes:
> In extension_config_remove() we first ensure that pg_extension.extconfig cannot
> contain any NULL values in the array, ERRORing out if so.  Later we however ask
> for NULL values back when deconstructing the array, throwing away the results
> knowing there wont be any, which seems superfluous (and wrong if there indeed
> were any).  The attached patch signals to deconstruct_array() that any NULL
> values should be considered an error instead of returned, to keep NULL value
> handling consistent (and shave two small allocations off).

LGTM, pushed.

            regards, tom lane