Обсуждение: Unnecessary asterisk in comment in postgres_fdw.c
Here is a small patch for removing $SUBJECT. Best regards, Etsuro Fujita
Вложения
On Wed, Nov 28, 2018 at 03:25:34PM +0900, Etsuro Fujita wrote: > Here is a small patch for removing $SUBJECT. Agreed. Patch applied through PG 10, where this first appeared. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
On 2018-Nov-28, Bruce Momjian wrote: > On Wed, Nov 28, 2018 at 03:25:34PM +0900, Etsuro Fujita wrote: > > Here is a small patch for removing $SUBJECT. > > Agreed. Patch applied through PG 10, where this first appeared. Why wouldn't Fujita-san push this patch himself? -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Wed, Nov 28, 2018 at 10:46:51AM -0300, Alvaro Herrera wrote: > On 2018-Nov-28, Bruce Momjian wrote: > > > On Wed, Nov 28, 2018 at 03:25:34PM +0900, Etsuro Fujita wrote: > > > Here is a small patch for removing $SUBJECT. > > > > Agreed. Patch applied through PG 10, where this first appeared. > > Why wouldn't Fujita-san push this patch himself? I was wondering that myself, but thought maybe he was busy and wanted someone else to do it. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
On Wed, Nov 28, 2018 at 08:51:54AM -0500, Bruce Momjian wrote: > On Wed, Nov 28, 2018 at 10:46:51AM -0300, Alvaro Herrera wrote: > > On 2018-Nov-28, Bruce Momjian wrote: > > > > > On Wed, Nov 28, 2018 at 03:25:34PM +0900, Etsuro Fujita wrote: > > > > Here is a small patch for removing $SUBJECT. > > > > > > Agreed. Patch applied through PG 10, where this first appeared. > > > > Why wouldn't Fujita-san push this patch himself? > > I was wondering that myself, but thought maybe he was busy and wanted > someone else to do it. Actually, it was so simple I thought he would just apply it, but he might have been following the protocol of posting the patch first, and in that case, I interfered by applying it. Sorry. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
(2018/11/28 23:31), Bruce Momjian wrote: > On Wed, Nov 28, 2018 at 08:51:54AM -0500, Bruce Momjian wrote: >> On Wed, Nov 28, 2018 at 10:46:51AM -0300, Alvaro Herrera wrote: >>> On 2018-Nov-28, Bruce Momjian wrote: >>> >>>> On Wed, Nov 28, 2018 at 03:25:34PM +0900, Etsuro Fujita wrote: >>>>> Here is a small patch for removing $SUBJECT. >>>> >>>> Agreed. Patch applied through PG 10, where this first appeared. >>> >>> Why wouldn't Fujita-san push this patch himself? >> >> I was wondering that myself, but thought maybe he was busy and wanted >> someone else to do it. > > Actually, it was so simple I thought he would just apply it, but he > might have been following the protocol of posting the patch first, and > in that case, I interfered by applying it. Sorry. No problem! Thanks for taking care of this, Bruce! (I also thought that was simple, but my first language is not English, so I thought it would be better to give others a chance for reviewing that. Maybe my explanation in a previous email was not enough. Sorry about that.) Best regards, Etsuro Fujita