Обсуждение: patch tester symbols
Hi, Context: I'm trying to compile the jsonpath v36 patches (these apply OK), and on top of those the jsonfunctions and jsontable patch series. That fails for me (on 0001-Implementation-of-SQL-JSON-path-language-v36.patch), and now I'm wondering why that does not agree with what the patch-tester page shows ( http://commitfest.cputube.org/ ). The patch-tester page does not explain what the colors and symbols mean. Of course one can guess 'red' and 'cross' is bad, and 'green' and 'check' is good. But some questions remain: - Some symbols' color is 'filled-in' (solid), and some are not. What does that mean? - For each patch there are three symbols; what do those three stand for? - I suppose there is a regular schedule of apply and compile of each patch. How often does it happen? Can I see how recent a particular reported state is? Can you throw some light on this? thanks, Erik Rijkes
On 06.03.2019 13:11, Erik Rijkers wrote: > Hi, > > Context: I'm trying to compile the jsonpath v36 patches (these apply > OK), and on top of those the jsonfunctions and jsontable patch series. > > That fails for me (on > 0001-Implementation-of-SQL-JSON-path-language-v36.patch), and now I'm > wondering why that does not agree with what the patch-tester page > shows ( http://commitfest.cputube.org/ ). > Patch 0001-Implementation-of-SQL-JSON-path-language-v36.patch from the "SQL/JSON: functions" patch set is a simply squash of all 6 jsonpath patches on which this patch set depends. I included it into this patch set just for testing in patch-tester (I guess patch-tester cannot handle patch dependencies). If you apply SQL/JSON patch sets step by step, then you need to apply only patch 0002 from "SQL/JSON: functions" and "SQL/JSON: JSON_TABLE". -- Nikita Glukhov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
On 2019-03-06 13:00, Nikita Glukhov wrote: > On 06.03.2019 13:11, Erik Rijkers wrote: >> Context: I'm trying to compile the jsonpath v36 patches (these apply >> OK), and on top of those the jsonfunctions and jsontable patch series. > Patch 0001-Implementation-of-SQL-JSON-path-language-v36.patch from the > "SQL/JSON: functions" patch set is a simply squash of all 6 jsonpath > patches on which this patch set depends. I included it into this patch > set just for testing in patch-tester (I guess patch-tester cannot > handle patch dependencies). If you apply SQL/JSON patch sets step by > step, then you need to apply only patch 0002 from "SQL/JSON: > functions" and "SQL/JSON: JSON_TABLE". Ah, that explains it. I suppose I should have guessed that. Applied in that way it built fine (apply, compile, check-world OK). Thank you, Erik Rijkers