Обсуждение: Small doc fix for pageinspect

Поиск
Список
Период
Сортировка

Small doc fix for pageinspect

От
Laurenz Albe
Дата:
I noticed today that the signature for two functions is wrong
in the documentation:

- "heap_page_item_attrs" has the argument order and return type wrong
  and is lacking types

- "tuple_data_split" is lacking the type for "rel_oid"

Patch attached.

This should be backpatched down to 9.6 where the functions have been added.

Yours,
Laurenz Albe

Вложения

Re: Small doc fix for pageinspect

От
Michael Paquier
Дата:
On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:
> This should be backpatched down to 9.6 where the functions have been
> added.

Thanks, applied.  The second argument name of heap_page_item_attrs is
actually "page", and not "t_data", so both your patch and the docs
were wrong on this point.
--
Michael

Вложения

Re: Small doc fix for pageinspect

От
Laurenz Albe
Дата:
Michael Paquier wrote:
> On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:
> > This should be backpatched down to 9.6 where the functions have been
> > added.
> 
> Thanks, applied.  The second argument name of heap_page_item_attrs is
> actually "page", and not "t_data", so both your patch and the docs
> were wrong on this point.

Thanks, and pardon the sloppiness.

Yours,
Laurenz Albe