Обсуждение: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

Поиск
Список
Период
Сортировка

[pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Dave Page
Дата:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers.

Kindly review.

On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Aditya Toshniwal
Дата:
Hi Hackers,

Kindly hold on with the patch. I think I have missed few things. :P
Will send an updated patch.

On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers.

Kindly review.

On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Aditya Toshniwal
Дата:
Hi Hackers,

Attached is the updated patch.
The patch also includes some RE-SQL log additions and a change in resql code where msql was failing if scenario data had dict data types. Code is changed to convert dict to string before forming the URL.

Kindly review.

On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Kindly hold on with the patch. I think I have missed few things. :P
Will send an updated patch.

On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers.

Kindly review.

On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

Re: [pgAdmin][RM4469] Add RE-SQL test cases for Sequences

От
Akshay Joshi
Дата:
Thanks patch applied.

On Thu, Aug 29, 2019 at 12:29 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated patch.
The patch also includes some RE-SQL log additions and a change in resql code where msql was failing if scenario data had dict data types. Code is changed to convert dict to string before forming the URL.

Kindly review.

On Thu, Aug 29, 2019 at 11:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Kindly hold on with the patch. I think I have missed few things. :P
Will send an updated patch.

On Wed, Aug 28, 2019 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch containing further changes to sequences RE-SQL test cases. Changes include MSQL test cases, ACL test cases and allow run sequences test cases on EPAS servers.

Kindly review.

On Mon, Jul 15, 2019 at 7:26 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, committed.

On Mon, Jul 15, 2019 at 12:06 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to add RE-SQL test cases for sequences. When running the test cases, I also found an issue (#4470). The fix for it is included in the patch.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246