Обсуждение: [pgAdmin][RM4553] Query tool UX improvement
Hi Hackers,
Attached is the patch to improve user experience when opening query tool.
Previously, when the query tool button was clicked, the request went to backend, the connection was created and sent back to the UI. Until then, there was no activity on the UI. For slow servers it looked like pgAdmin is slow/struck.
With this change, the query tool will be opened instantaneously. Other things like opening the connection is done in parallel with query tool render, thus saving time.
The query tool connection status icon will show a spinner and text will have "Obtaining connection..." until the connection is established.
Test cases added/changed accordingly.
Kindly review.
-- Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения
Forgot to mention, this patch also fixes https://redmine.postgresql.org/issues/4584 - HTML entities aren't escaped in database names
On Thu, Aug 22, 2019 at 1:05 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Attached is the patch to improve user experience when opening query tool.Previously, when the query tool button was clicked, the request went to backend, the connection was created and sent back to the UI. Until then, there was no activity on the UI. For slow servers it looked like pgAdmin is slow/struck.With this change, the query tool will be opened instantaneously. Other things like opening the connection is done in parallel with query tool render, thus saving time.The query tool connection status icon will show a spinner and text will have "Obtaining connection..." until the connection is established.Test cases added/changed accordingly.Kindly review.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Nice! Patch applied, thanks.
On Thu, Aug 22, 2019 at 9:08 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Forgot to mention, this patch also fixes https://redmine.postgresql.org/issues/4584 - HTML entities aren't escaped in database namesOn Thu, Aug 22, 2019 at 1:05 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached is the patch to improve user experience when opening query tool.Previously, when the query tool button was clicked, the request went to backend, the connection was created and sent back to the UI. Until then, there was no activity on the UI. For slow servers it looked like pgAdmin is slow/struck.With this change, the query tool will be opened instantaneously. Other things like opening the connection is done in parallel with query tool render, thus saving time.The query tool connection status icon will show a spinner and text will have "Obtaining connection..." until the connection is established.Test cases added/changed accordingly.Kindly review.--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company