Обсуждение: Resql test cases for views and fix for bug: 4650
Hi Hackers,
--
Thanks,
Usman Muzaffar
QA Team
EnterpriseDB Corporation
Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
- Fix for bug # 4650
- Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
- yarn run pep8
- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.
EnterpriseDB Corporation
Вложения
Just a correction, bug reference in above mail should be 4486 instead of 4650.
On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Hi Hackers,Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
- Fix for bug # 4650
- Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
- yarn run pep8
- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.
--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation
EnterpriseDB Corporation
Hi Usman
I have modified the code, please work on the following test cases:
- No test case for privileges at all.
- We should add alter test cases for check_option, security_barrier and privileges.
On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Just a correction, bug reference in above mail should be 4486 instead of 4650.On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:Hi Hackers,Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
- Fix for bug # 4650
- Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
- yarn run pep8
- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.
--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения
Hi,
Please find here updated patch with the above required test cases.
Please review and commit the changes
On Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi UsmanI have modified the code, please work on the following test cases:Attached is the modified patch, please continue your work on it.
- No test case for privileges at all.
- We should add alter test cases for check_option, security_barrier and privileges.
On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:Just a correction, bug reference in above mail should be 4486 instead of 4650.On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:Hi Hackers,Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
- Fix for bug # 4650
- Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
- yarn run pep8
- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.
--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
EnterpriseDB Corporation
Вложения
Thanks patch applied.
On Tue, Aug 27, 2019 at 8:02 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:
Hi,Please find here updated patch with the above required test cases.Please review and commit the changesOn Tue, Aug 27, 2019 at 12:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi UsmanI have modified the code, please work on the following test cases:Attached is the modified patch, please continue your work on it.
- No test case for privileges at all.
- We should add alter test cases for check_option, security_barrier and privileges.
On Tue, Aug 27, 2019 at 12:12 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:Just a correction, bug reference in above mail should be 4486 instead of 4650.On Mon, Aug 26, 2019 at 7:50 PM Usman Muzaffar <usman.muzaffar@enterprisedb.com> wrote:Hi Hackers,Please find here attached patch for sql re engineering test cases for views node. As part of this patch I have also incorported followings
- Fix for bug # 4650
- Also modified views/template/create.sql due to which, apparently same output and input was not matching for test cases.
Following are verified before sending the patch
- yarn run pep8
- verified test cases on all pg/ppas server e.g. pg 9.4 to 11 and ppas 9.4 to 11.
--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246--QA TeamUsman MuzaffarThanks,
EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246