Обсуждение: PostgreSQL 12 release notes missing breaking change in libpq

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/12/release-12.html
Description:

Hi!

In PostgreSQL 12, libpq's parsing of connection string integer parameters
was made more strict, such that invalid values now result in an error rather
than being silently ignored:
https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb

This change resulted in runtime errors/crashes for some of our customers
after we upgraded the Heroku stack images to use v12 of the PostgreSQL
client libs.

We had checked the release notes, but it's not currently mentioned:
https://www.postgresql.org/docs/12/release-12.html

Please could it be added?

Many thanks,

Ed

On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> In PostgreSQL 12, libpq's parsing of connection string integer parameters
> was made more strict, such that invalid values now result in an error rather
> than being silently ignored:
> https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
>
> This change resulted in runtime errors/crashes for some of our customers
> after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> client libs.
>
> We had checked the release notes, but it's not currently mentioned:
> https://www.postgresql.org/docs/12/release-12.html
>
> Please could it be added?

I think it makes sense to mention that.  Bruce, why not adding an item
about that in the "Migration to Version 12" section?  Was that
intentionally left out?
--
Michael

On Thu, Oct 17, 2019 at 10:33:10AM +0900, Michael Paquier wrote:
> On Wed, Oct 16, 2019 at 01:12:36PM +0000, PG Doc comments form wrote:
> > In PostgreSQL 12, libpq's parsing of connection string integer parameters
> > was made more strict, such that invalid values now result in an error rather
> > than being silently ignored:
> > https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
> > 
> > This change resulted in runtime errors/crashes for some of our customers
> > after we upgraded the Heroku stack images to use v12 of the PostgreSQL
> > client libs.
> > 
> > We had checked the release notes, but it's not currently mentioned:
> > https://www.postgresql.org/docs/12/release-12.html
> > 
> > Please could it be added?
> 
> I think it makes sense to mention that.  Bruce, why not adding an item
> about that in the "Migration to Version 12" section?  Was that
> intentionally left out?

My reading of the commit message is that the error messages will just be
more helpful now, not that some things would now error that use to be
ignored.  I am still unclear exactly what the release notes should say.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> My reading of the commit message is that the error messages will just be
> more helpful now, not that some things would now error that use to be
> ignored.  I am still unclear exactly what the release notes should say.

Nay.  It could be worse as in some cases like for the keepalive
parameters, the values would be just silently ignored.  Please let me
suggest the attached for the release notes of REL_12_STABLE.
--
Michael

On Wed, Oct 30, 2019 at 01:29:48PM +0900, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> > My reading of the commit message is that the error messages will just be
> > more helpful now, not that some things would now error that use to be
> > ignored.  I am still unclear exactly what the release notes should say.
> 
> Nay.  It could be worse as in some cases like for the keepalive
> parameters, the values would be just silently ignored.  Please let me
> suggest the attached for the release notes of REL_12_STABLE.

Thanks for the patch.  I slightly modified the wording and applied the
attached patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

On Wed, Oct 30, 2019 at 01:43:55PM -0400, Bruce Momjian wrote:
> Thanks for the patch.  I slightly modified the wording and applied the
> attached patch.

Thanks Bruce!
--
Michael