Обсуждение: Typos and inconsistencies in code
Hi, Please find the attached patch having the fix for the typos and inconsistencies present in code. The patch contains the following changes: 1) attibute -> attribute 2) efficent -> efficient 3) becuase -> because 4) fallthru -> fall through 5) uncoming -> upcoming 6) ans -> and 7) requrested -> requested 8) peforming -> performing 9) heartbearts -> heartbeats 10) parametrizing -> parameterizing 11) uninit -> uninitialized 12) bufgr -> bufmgr 13) directi -> direct 14) thead -> thread 15) somthing -> something 16) freek -> freak 17) changesd -> changes Let me know your thoughts on the same. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
Вложения
On Mon, Oct 28, 2019 at 11:22 PM vignesh C <vignesh21@gmail.com> wrote: > > Hi, > > Please find the attached patch having the fix for the typos and > inconsistencies present in code. > The patch contains the following changes: > 1) attibute -> attribute > 2) efficent -> efficient > 3) becuase -> because > 4) fallthru -> fall through > 5) uncoming -> upcoming > 6) ans -> and > 7) requrested -> requested > 8) peforming -> performing > 9) heartbearts -> heartbeats > 10) parametrizing -> parameterizing > 11) uninit -> uninitialized > 12) bufgr -> bufmgr > 13) directi -> direct > 14) thead -> thread > 15) somthing -> something > 16) freek -> freak > 17) changesd -> changes > > Let me know your thoughts on the same. > Few comments: 1. * The act of allocating pages to recycle may have invalidated the - * results of our previous btree reserch, so repeat it. (We could + * results of our previous btree search, so repeat it. (We could * recheck whether any of our split-avoidance strategies that were I think the old comment meant "btree research" but you changed to "btree search" 2. /* copy&pasted from .../src/backend/utils/adt/datetime.c - * and changesd struct pg_tm to struct tm + * and changes struct pg_tm to struct tm */ Seems like this comment meant "Changed struct pg_tm to struct tm" -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
On Tue, Oct 29, 2019 at 9:19 AM Dilip Kumar <dilipbalaut@gmail.com> wrote: > > Few comments: > 1. > * The act of allocating pages to recycle may have invalidated the > - * results of our previous btree reserch, so repeat it. (We could > + * results of our previous btree search, so repeat it. (We could > * recheck whether any of our split-avoidance strategies that were > Fixed > I think the old comment meant "btree research" but you changed to "btree search" > > 2. > /* copy&pasted from .../src/backend/utils/adt/datetime.c > - * and changesd struct pg_tm to struct tm > + * and changes struct pg_tm to struct tm > */ > Seems like this comment meant "Changed struct pg_tm to struct tm" Fixed Thanks for the review. I have attached the updated patch with the fixes. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
Вложения
On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote: > I have attached the updated patch with the fixes. The changes in rangetypes_gist.c are not correct, the usual pattern to add an "s" after the structure name is quite common when referring to multiple elements. We could perhaps use "put-your-struct entries" instead, but I have seen the pattern of HEAD quite a lot as well (see also for example mcv.c with SortItem that is a file your patch touches). A comment indentation was wrong in detoast.c, not the fault of this patch but I have fixed it at the same time. Note: there is room for refactoring in pgtypeslib with the pg_tm/tm business.. The fixes in imath.c had better be submitted in upstream: https://github.com/creachadair/imath/blob/v1.29/imath.c So I have raised an issue here: https://github.com/creachadair/imath/issues/43 -- Michael
Вложения
On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote: > > I have attached the updated patch with the fixes. > > The changes in rangetypes_gist.c are not correct, the usual pattern to > add an "s" after the structure name is quite common when referring to > multiple elements. We could perhaps use "put-your-struct entries" > instead, but I have seen the pattern of HEAD quite a lot as well (see > also for example mcv.c with SortItem that is a file your patch > touches). > > A comment indentation was wrong in detoast.c, not the fault of this > patch but I have fixed it at the same time. > Thanks for pushing the changes Michael. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com