Обсуждение: favicons

Поиск
Список
Период
Сортировка

favicons

От
Peter Eisentraut
Дата:
www.postgresql.org and commitfest.postgresql.org appear to have 
different favicons that look just slightly different in a browser tab 
bar.  Perhaps a common one could be found.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: favicons

От
Daniel Gustafsson
Дата:
> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly different
ina browser tab bar.  Perhaps a common one could be found. 

Nice catch, I hadn't realized but now I can't unsee it.  From a quick
inspection, the commitfest favicon is the old low-res icon so we should use the
pgweb file for the commitfest.

cheers ./daniel


Re: favicons

От
Marcin Cieslak
Дата:
On Thu, 30 Jan 2020, Daniel Gustafsson wrote:

>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly different
ina browser tab bar.  Perhaps a common one could be found.
 
>
> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
> inspection, the commitfest favicon is the old low-res icon so we should use the
> pgweb file for the commitfest.

New favicons were generated automatically (the code is available at
https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
There was at least one report here that they do not look good in all cases,
as reported by Peter Geoghegan before.

I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.

Marcin
Вложения

Re: favicons

От
Daniel Gustafsson
Дата:
On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:

On Thu, 30 Jan 2020, Daniel Gustafsson wrote:

On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly different in a browser tab bar.  Perhaps a common one could be found.

Nice catch, I hadn't realized but now I can't unsee it.  From a quick
inspection, the commitfest favicon is the old low-res icon so we should use the
pgweb file for the commitfest.

New favicons were generated automatically (the code is available at
https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
There was at least one report here that they do not look good in all cases,
as reported by Peter Geoghegan before.

I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.

The attached screenshot has postgresql.org on the left and the CF app on the
right (in Firefox).

cheers ./daniel

Вложения

Re: favicons

От
Bruce Momjian
Дата:
On Thu, Jan 30, 2020 at 02:01:57PM +0100, Daniel Gustafsson wrote:
> > On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:
> > 
> > On Thu, 30 Jan 2020, Daniel Gustafsson wrote:
> > 
> >>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> >>> 
> >>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly
differentin a browser tab bar.  Perhaps a common one could be found.
 
> >> 
> >> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
> >> inspection, the commitfest favicon is the old low-res icon so we should use the
> >> pgweb file for the commitfest.
> > 
> > New favicons were generated automatically (the code is available at
> > https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
> > There was at least one report here that they do not look good in all cases,
> > as reported by Peter Geoghegan before.
> > 
> > I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.
> 
> The attached screenshot has postgresql.org on the left and the CF app on the
> right (in Firefox).

Yes, this been fixed?  I don't think so.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



Re: favicons

От
"Jonathan S. Katz"
Дата:
On 3/23/20 9:50 PM, Bruce Momjian wrote:
> On Thu, Jan 30, 2020 at 02:01:57PM +0100, Daniel Gustafsson wrote:
>>> On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:
>>>
>>> On Thu, 30 Jan 2020, Daniel Gustafsson wrote:
>>>
>>>>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>>>
>>>>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly
differentin a browser tab bar.  Perhaps a common one could be found. 
>>>>
>>>> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
>>>> inspection, the commitfest favicon is the old low-res icon so we should use the
>>>> pgweb file for the commitfest.
>>>
>>> New favicons were generated automatically (the code is available at
>>> https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
>>> There was at least one report here that they do not look good in all cases,
>>> as reported by Peter Geoghegan before.
>>>
>>> I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.
>>
>> The attached screenshot has postgresql.org on the left and the CF app on the
>> right (in Firefox).
>
> Yes, this been fixed?  I don't think so.

Someone with commit privs on the commitfest app will have to update it.
The source of the favicon is in the pgweb tree here:

https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=media/favicon.ico;;hb=HEAD

Jonathan


Вложения

Re: favicons

От
"Jonathan S. Katz"
Дата:
On 3/23/20 9:55 PM, Jonathan S. Katz wrote:
> On 3/23/20 9:50 PM, Bruce Momjian wrote:
>> On Thu, Jan 30, 2020 at 02:01:57PM +0100, Daniel Gustafsson wrote:
>>>> On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:
>>>>
>>>> On Thu, 30 Jan 2020, Daniel Gustafsson wrote:
>>>>
>>>>>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>>>>
>>>>>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly
differentin a browser tab bar.  Perhaps a common one could be found. 
>>>>>
>>>>> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
>>>>> inspection, the commitfest favicon is the old low-res icon so we should use the
>>>>> pgweb file for the commitfest.
>>>>
>>>> New favicons were generated automatically (the code is available at
>>>> https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
>>>> There was at least one report here that they do not look good in all cases,
>>>> as reported by Peter Geoghegan before.
>>>>
>>>> I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.
>>>
>>> The attached screenshot has postgresql.org on the left and the CF app on the
>>> right (in Firefox).
>>
>> Yes, this been fixed?  I don't think so.
>
> Someone with commit privs on the commitfest app will have to update it.
> The source of the favicon is in the pgweb tree here:
>
> https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=media/favicon.ico;;hb=HEAD

Attached a patch for convenience.

Jonathan

Вложения

Re: favicons

От
Bruce Momjian
Дата:
On Mon, Mar 23, 2020 at 09:59:32PM -0400, Jonathan Katz wrote:
> On 3/23/20 9:55 PM, Jonathan S. Katz wrote:
> > On 3/23/20 9:50 PM, Bruce Momjian wrote:
> >> On Thu, Jan 30, 2020 at 02:01:57PM +0100, Daniel Gustafsson wrote:
> >>>> On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:
> >>>>
> >>>> On Thu, 30 Jan 2020, Daniel Gustafsson wrote:
> >>>>
> >>>>>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> >>>>>>
> >>>>>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly
differentin a browser tab bar.  Perhaps a common one could be found.
 
> >>>>>
> >>>>> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
> >>>>> inspection, the commitfest favicon is the old low-res icon so we should use the
> >>>>> pgweb file for the commitfest.
> >>>>
> >>>> New favicons were generated automatically (the code is available at
> >>>> https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
> >>>> There was at least one report here that they do not look good in all cases,
> >>>> as reported by Peter Geoghegan before.
> >>>>
> >>>> I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.
> >>>
> >>> The attached screenshot has postgresql.org on the left and the CF app on the
> >>> right (in Firefox).
> >>
> >> Yes, this been fixed?  I don't think so.
> > 
> > Someone with commit privs on the commitfest app will have to update it.
> > The source of the favicon is in the pgweb tree here:
> > 
> > https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=media/favicon.ico;;hb=HEAD
> 
> Attached a patch for convenience.

OK, who has commit rights to the commit fest app?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +



Re: favicons

От
Daniel Gustafsson
Дата:
> On 24 Mar 2020, at 03:14, Bruce Momjian <bruce@momjian.us> wrote:

> OK, who has commit rights to the commit fest app?

Judging by the history, it's at least Magnus and Dave.

$ git log --format=fuller | grep Commit: | sort -u
Commit:     Dave Page <dpage@pgadmin.org>
Commit:     Magnus Hagander <magnus@hagander.net>

cheers ./daniel



Re: favicons

От
Dave Page
Дата:


On Tue, Mar 24, 2020 at 1:59 AM Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 3/23/20 9:55 PM, Jonathan S. Katz wrote:
> On 3/23/20 9:50 PM, Bruce Momjian wrote:
>> On Thu, Jan 30, 2020 at 02:01:57PM +0100, Daniel Gustafsson wrote:
>>>> On 30 Jan 2020, at 13:09, Marcin Cieslak <saper@saper.info> wrote:
>>>>
>>>> On Thu, 30 Jan 2020, Daniel Gustafsson wrote:
>>>>
>>>>>> On 29 Jan 2020, at 16:44, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>>>>
>>>>>> www.postgresql.org and commitfest.postgresql.org appear to have different favicons that look just slightly different in a browser tab bar.  Perhaps a common one could be found.
>>>>>
>>>>> Nice catch, I hadn't realized but now I can't unsee it.  From a quick
>>>>> inspection, the commitfest favicon is the old low-res icon so we should use the
>>>>> pgweb file for the commitfest.
>>>>
>>>> New favicons were generated automatically (the code is available at
>>>> https://repo.or.cz/pgweb-favicon.git ) but I guess it could be improved.
>>>> There was at least one report here that they do not look good in all cases,
>>>> as reported by Peter Geoghegan before.
>>>>
>>>> I'd appreciate some screenshots (maybe real screen photos?) to see what's looking weird.
>>>
>>> The attached screenshot has postgresql.org on the left and the CF app on the
>>> right (in Firefox).
>>
>> Yes, this been fixed?  I don't think so.
>
> Someone with commit privs on the commitfest app will have to update it.
> The source of the favicon is in the pgweb tree here:
>
> https://git.postgresql.org/gitweb/?p=pgweb.git;a=blob;f=media/favicon.ico;;hb=HEAD

Attached a patch for convenience.

Thanks, committed. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company