Обсуждение: [PATCH v1] Allow COPY "text" format to output a header

Поиск
Список
Период
Сортировка

[PATCH v1] Allow COPY "text" format to output a header

От
Rémi Lapeyre
Дата:
This patch adds the possibility to use the "header" option when using COPY with
the text format. A todo entry was opened for this and I updated the tests and
the documentation.

This was previously discussed at
https://www.postgresql.org/message-id/flat/CACfv%2BpJ31tesLvncJyP24quo8AE%2BM0GP6p6MEpwPv6yV8%3DsVHQ%40mail.gmail.com

Greetings,
Rémi

---
 doc/src/sgml/ref/copy.sgml          |  3 +-
 src/backend/commands/copy.c         | 11 ++++---
 src/test/regress/input/copy.source  | 46 +++++++++++++++++++----------
 src/test/regress/output/copy.source | 41 +++++++++++++++----------
 4 files changed, 64 insertions(+), 37 deletions(-)


Вложения

Re: [PATCH v1] Allow COPY "text" format to output a header

От
Surafel Temesgen
Дата:
Hi,
On Tue, Feb 4, 2020 at 4:25 PM Rémi Lapeyre <remi.lapeyre@henki.fr> wrote:
This patch adds the possibility to use the "header" option when using COPY with
the text format. A todo entry was opened for this and I updated the tests and
the documentation.

This was previously discussed at https://www.postgresql.org/message-id/flat/CACfv%2BpJ31tesLvncJyP24quo8AE%2BM0GP6p6MEpwPv6yV8%3DsVHQ%40mail.gmail.com


 and among feedback given is to adding header matching feature on to this.

regards
Surafel

Re: [PATCH v1] Allow COPY "text" format to output a header

От
Rémi Lapeyre
Дата:
>
> FWIW there was more recent propose patch at
https://www.postgresql.org/message-id/flat/CAF1-J-0PtCWMeLtswwGV2M70U26n4g33gpe1rcKQqe6wVQDrFA@mail.gmail.com
>  and among feedback given is to adding header matching feature on to this.

Thanks for the feedback. What should happen now? Can I just move the patch to the current Commitfest and send a new
patchto the old thread? 


Re: [PATCH v1] Allow COPY "text" format to output a header

От
Surafel Temesgen
Дата:



On Wed, Feb 5, 2020 at 4:19 PM Rémi Lapeyre <remi.lapeyre@henki.fr> wrote:
>
> FWIW there was more recent propose patch at https://www.postgresql.org/message-id/flat/CAF1-J-0PtCWMeLtswwGV2M70U26n4g33gpe1rcKQqe6wVQDrFA@mail.gmail.com
>  and among feedback given is to adding header matching feature on to this.

Thanks for the feedback. What should happen now? Can I just move the patch to the current Commitfest and send a new patch to the old thread?

Both way is possible you can add this tread with feedback incorporated patch or you can add old tread with a new patch

regards
Surafel