Обсуждение: Fix in switch cell tab navigation

Hi Hackers,

Attached is the patch for below minor fix in the switch cell tab navigation:

After pressing the tab key on switch cell, sometimes focus doesn't go to the immediate next editable cell. It goes to the different cell for fraction of seconds and again comes to the next editable cell.

Please review.

Regards,

Ganesh Jaybhay

Hi Ganesh,

You have put a check on subgrid-cell class, which does not exist in the entire source code.

Also, can you please let me know of any module which you have tested, so I can test accordingly though the code for the same looks good to me.

Thanks,

Khushboo

On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch for below minor fix in the switch cell tab navigation:

After pressing the tab key on switch cell, sometimes focus doesn't go to the immediate next editable cell. It goes to the different cell for fraction of seconds and again comes to the next editable cell.

Please review.

Regards,

Ganesh Jaybhay

Hi Khushboo,

I have removed the condition added for subgrid-cell. Please find the attached updated patch

Regards,

Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

Hi Ganesh,

You have put a check on subgrid-cell class, which does not exist in the entire source code.

Also, can you please let me know of any module which you have tested, so I can test accordingly though the code for the same looks good to me.

Thanks,

Khushboo

On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch for below minor fix in the switch cell tab navigation:

After pressing the tab key on switch cell, sometimes focus doesn't go to the immediate next editable cell. It goes to the different cell for fraction of seconds and again comes to the next editable cell.

Please review.

Regards,

Ganesh Jaybhay