Обсуждение: Vintage unused variables in pg_dump.c

Unless I'm missing something, the g_comment_start and g_comment_end variables
in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
cycle) and can probably be safely removed by now.  The attached passes make
check.

cheers ./daniel

Daniel Gustafsson <daniel@yesql.se> writes:
> Unless I'm missing something, the g_comment_start and g_comment_end variables
> in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
> cycle) and can probably be safely removed by now.

Indeed.  (Well, I didn't verify your statement about when they were
last used, but they're clearly dead now.)  Pushed.

            regards, tom lane