Обсуждение: pgsql: Improvements to psql \dAo and \dAp commands

Поиск
Список
Период
Сортировка

pgsql: Improvements to psql \dAo and \dAp commands

От
Alexander Korotkov
Дата:
Improvements to psql \dAo and \dAp commands

 * Strategy number and purpose are essential information for opfamily operator.
   So, show those columns in non-verbose output.
 * "Left/right arg type" \dAp column names are confusing, because those type
   don't necessary match to function arguments.  Rename them to "Registered
   left/right type".
 * Replace manual assembling of operator/procedure names with casts to
   regoperator/regprocedure.
 * Add schema-qualification for pg_catalog functions and tables.

Reported-by: Peter Eisentraut, Tom Lane
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/2edc7b27-031f-b2b6-0db2-864241c91cb9%402ndquadrant.com
Backpatch-through: 13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8d2ed66e4107ef27d05aef682c68af5952af7690

Modified Files
--------------
src/bin/psql/command.c             |  2 +-
src/bin/psql/describe.c            | 93 ++++++++++++++++++------------------
src/bin/psql/describe.h            |  2 +-
src/test/regress/expected/psql.out | 98 +++++++++++++++++++-------------------
src/test/regress/sql/psql.sql      |  2 +-
5 files changed, 98 insertions(+), 99 deletions(-)


Re: pgsql: Improvements to psql \dAo and \dAp commands

От
Alexander Korotkov
Дата:
On Mon, Jul 13, 2020 at 6:57 PM Alexander Korotkov
<akorotkov@postgresql.org> wrote:
> Improvements to psql \dAo and \dAp commands

Oops, I've just pushed the commit with timestamp too far in the past.
Sorry for that.

------
Regards,
Alexander Korotkov



Re: pgsql: Improvements to psql \dAo and \dAp commands

От
Tom Lane
Дата:
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Mon, Jul 13, 2020 at 6:57 PM Alexander Korotkov
> <akorotkov@postgresql.org> wrote:
>> Improvements to psql \dAo and \dAp commands

> Oops, I've just pushed the commit with timestamp too far in the past.
> Sorry for that.

Some committers use workflows where the author-date is regularly
well in the past.  Because of that, git_changelog and other tools
tend to look at the committer-date instead.  Don't sweat about it.

            regards, tom lane



Re: pgsql: Improvements to psql \dAo and \dAp commands

От
Alexander Korotkov
Дата:
On Mon, Jul 13, 2020 at 10:39 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
> > On Mon, Jul 13, 2020 at 6:57 PM Alexander Korotkov
> > <akorotkov@postgresql.org> wrote:
> >> Improvements to psql \dAo and \dAp commands
>
> > Oops, I've just pushed the commit with timestamp too far in the past.
> > Sorry for that.
>
> Some committers use workflows where the author-date is regularly
> well in the past.  Because of that, git_changelog and other tools
> tend to look at the committer-date instead.  Don't sweat about it.

Got it, thanks!

------
Regards,
Alexander Korotkov