Обсуждение: SonarQube Fixes #3
Hi Hackers,
--
Please find the attached patch to fix the SonarQube code smells having rules:
- Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
Also, corrected one of the backup test cases which were failing in server mode.
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Вложения
Hi Hackers,
Minor sonar issues too fixed. Find the updated patch.
On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,Please find the attached patch to fix the SonarQube code smells having rules:
- Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
Also, corrected one of the backup test cases which were failing in server mode.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Вложения
Hi Hackers,
Please find below attached patch which fixes:
1. Bgprocess watcher dialog box disappearing after server is removed
2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to Storage Manager)
3. Previous sonarqube issues carry forward in this patch.
Rest I haven't got any user_old specific issues while removing the orphan process, I think, programmatically, it is handled.
Note: Previous sonarqube issue in this mail trace is also considered in this patch due to many similar file changes.
On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,Minor sonar issues too fixed. Find the updated patch.On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch to fix the SonarQube code smells having rules:
- Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
Also, corrected one of the backup test cases which were failing in server mode.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.
Вложения
Thanks, patch applied.
On Thu, Nov 12, 2020 at 2:15 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,Please find below attached patch which fixes:1. Bgprocess watcher dialog box disappearing after server is removed2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to Storage Manager)3. Previous sonarqube issues carry forward in this patch.Rest I haven't got any user_old specific issues while removing the orphan process, I think, programmatically, it is handled.Note: Previous sonarqube issue in this mail trace is also considered in this patch due to many similar file changes.On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:Hi Hackers,Minor sonar issues too fixed. Find the updated patch.On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch to fix the SonarQube code smells having rules:
- Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed.
Also, corrected one of the backup test cases which were failing in server mode.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.--Rahul ShirsatSoftware Engineer | EnterpriseDB Corporation.
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246